From nobody Fri Jul 31 11:06:35 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBNYX4k2Zz6n2Gd for ; Fri, 31 Jul 2026 11:06:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBNYX40kSz45mQ for ; Fri, 31 Jul 2026 11:06:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785496000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ySRBArQDltrceLGFtvLdTENLdAR15XNRNeKcCI+8kgs=; b=bVYeIUI2qTcLyiaJqZ+S+dMhnR+QV/lgG6+XIeuQ4EGAdsVppL/R+y89UbnaHHeXfJn8QO 29XlS03MNZXJFZggLggAwC4zVfUroy+e+o7K+ZjLoxa93LBktGABBHRkcXEXJEHZ00EvVA UtaJODczIqjdsj4D5qQhP8Mfnp95M5x+y2hoiNn81fHtXvhj2b7zlrpd383zo+2fMCES6n yCVuJ0gd9DzKoKXrzMpT3BCXqZQCnscXl7PtmPu+8+IOLMLUTWMLqM14gptgAGVI4BQ2tv qEWIXYk6Rsr3eRcnDVlH8ZwKj7CbjgVvwAr5LMReDZGiWZccd3fbP5XIWXyYTw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785496000; a=rsa-sha256; cv=none; b=QzqlZi10v/Fiu8eUWpUdQYNHJ6yi+2Hs5NFQYxgcGrjpPxCOozm29+ZrMfDnNWzmsH47Si Vd+9p7/4gmJdUS+zT73YxsbZXJS17EctHgAqazMtJqnTFxMXQaiAoFpGTkDjyEruhK2jYI WWQ/8iuD19UNMgBjfFrTFTYNcSO2LgnMnauSHH1zQQehrGbh8oTFnEPy3ozf3c+H1MkWqb RXw9kn7KSaDnYRNuTx4TkpcQlmtmbtBCf2CP4PInbKSBMUQIvgur09Lo2MV4c+mdCBvazh LJXDFqhqzy+JNx6Hr5i3+qov7PgzHRE+MDEdSV3DgitR7dDJQtTMDl6MpPuWuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785496000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ySRBArQDltrceLGFtvLdTENLdAR15XNRNeKcCI+8kgs=; b=XJ9OwA5qG0Ysp7RXtUdJuY2wKLRb1ieToSYqVTtHvtMKr9O4eprS8eVU6pArfwuHx6Vd56 srHQvK8tv7FFD5f+VFKcb6AXgklTdQYIsPbAlf0KMvgARFbKpJSBZ2/GcwhbqLajbRdGl9 LkJUwX48WBDEViE1yGjmeJIEBmzlx1B5RhlQkMbrpCtVPxsvaHynMpG8rROigJlwSZs8bG v1vPvtH/rOiugK/bE+4qgeY603yL4ukpt8tFX+bZYn8Rw04AMZpPIiY0VQRUG2nDYUajZw a/urtJle7CLWvudQBYRZFsg0zQS8K++ZLkEEk6XEBDnAkzfYHUw2x/D+kYULng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBNYX2CbJzx9v for ; Fri, 31 Jul 2026 11:06:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bd01 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 11:06:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Daniil Iskhakov From: Kevin Bowling Subject: git: 21e03ab39603 - main - ixgbe: avoid flow control counter overflow List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 21e03ab39603fbab4bcef1dd61fe75e9e9276079 Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 11:06:35 +0000 Message-Id: <6a6c81bb.3bd01.57ec7754@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=21e03ab39603fbab4bcef1dd61fe75e9e9276079 commit 21e03ab39603fbab4bcef1dd61fe75e9e9276079 Author: Daniil Iskhakov AuthorDate: 2026-07-28 11:07:33 +0000 Commit: Kevin Bowling CommitDate: 2026-07-31 11:04:35 +0000 ixgbe: avoid flow control counter overflow DPDK commit message net/ixgbe: fix flow control frame byte adjustment LXONTXC and LXOFFTXC are 32-bit counters for transmitted XON and XOFF packets. Their deltas are summed and used to adjust the transmitted packet and byte counters. Perform the addition in 64 bits so it cannot wrap before the result is used for the byte adjustment. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Daniil Iskhakov Acked-by: Bruce Richardson Obtained from: DPDK (bdf8608559) MFC after: 1 week --- sys/dev/ixgbe/if_ix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index b9d88fcab523..b7ca21d4a313 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1882,9 +1882,9 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) { struct ixgbe_hw *hw = &sc->hw; struct ixgbe_hw_stats *stats = &sc->stats.pf; - u32 missed_rx = 0, bprc, lxon, lxoff, total; + u32 missed_rx = 0, bprc, lxon, lxoff; u32 lxoffrxc; - u64 total_missed_rx = 0; + u64 total_missed_rx = 0, total; stats->crcerrs += IXGBE_READ_REG(hw, IXGBE_CRCERRS); stats->illerrc += IXGBE_READ_REG(hw, IXGBE_ILLERRC); @@ -1953,7 +1953,7 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) stats->lxontxc += lxon; lxoff = IXGBE_READ_REG(hw, IXGBE_LXOFFTXC); stats->lxofftxc += lxoff; - total = lxon + lxoff; + total = (u64)lxon + lxoff; stats->gptc += IXGBE_READ_REG(hw, IXGBE_GPTC); stats->mptc += IXGBE_READ_REG(hw, IXGBE_MPTC);