From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Nov 18 10:21:10 2005
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@FreeBSD.org
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0818D16A423;
	Fri, 18 Nov 2005 10:21:10 +0000 (GMT)
	(envelope-from jdc@parodius.com)
Received: from mx1.parodius.com (mx1.parodius.com [64.62.145.229])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2C08543D67;
	Fri, 18 Nov 2005 10:21:09 +0000 (GMT)
	(envelope-from jdc@parodius.com)
Received: by mx1.parodius.com (Postfix, from userid 500)
	id 1204C5EAD; Fri, 18 Nov 2005 02:21:09 -0800 (PST)
Date: Fri, 18 Nov 2005 02:21:09 -0800
From: Jeremy Chadwick <freebsd@jdc.parodius.com>
To: Florent Thoumie <flz@FreeBSD.org>
Message-ID: <20051118102109.GA46737@pentarou.parodius.com>
References: <200511172205.jAHM5G4i076898@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200511172205.jAHM5G4i076898@freefall.freebsd.org>
User-Agent: Mutt/1.5.11
Cc: freebsd-ports-bugs@FreeBSD.org, vs@FreeBSD.org
Subject: Re: ports/83135: sysutils/smartmontools -- Does not work with
	alternate config location
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Nov 2005 10:21:10 -0000

Please re-open this PR.

The committed change does not work; the --configfile option
does not work (it appears to be broken code in smartd).  Using -c
does work, however.

The proper fix for smartd.sh is included below.


--- smartd.sh.old	Fri Nov 18 02:15:00 2005
+++ smartd.sh	Fri Nov 18 02:19:20 2005
@@ -25,7 +25,7 @@
 load_rc_config $name
 
 : ${smartd_config="/usr/local/etc/smartd.conf"}
-: ${smartd_flags="--configfile=${smartd_config}"}
+: ${smartd_flags="-c ${smartd_config}"}
 
 pidfile="${smartd_pidfile}"
 required_files="${smartd_config}"