From owner-freebsd-net@FreeBSD.ORG  Sun Jan 22 11:47:44 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A7B281065670
	for <freebsd-net@freebsd.org>; Sun, 22 Jan 2012 11:47:44 +0000 (UTC)
	(envelope-from nvass@gmx.com)
Received: from mailout-us.mail.com (mailout-us.gmx.com [74.208.5.67])
	by mx1.freebsd.org (Postfix) with SMTP id 136C08FC13
	for <freebsd-net@freebsd.org>; Sun, 22 Jan 2012 11:47:44 +0000 (UTC)
Received: (qmail invoked by alias); 22 Jan 2012 11:47:42 -0000
Received: from unknown (EHLO [192.168.73.192]) [91.140.99.89]
	by mail.gmx.com (mp-us008) with SMTP; 22 Jan 2012 06:47:42 -0500
X-Authenticated: #46156728
X-Provags-ID: V01U2FsdGVkX19ZfLpPVRVZ6N+oMnnw00sdLFBAQMe7Ta0FpljBJA
	/wfBYBjGqVTriS
Message-ID: <4F1BF757.7090701@gmx.com>
Date: Sun, 22 Jan 2012 13:47:35 +0200
From: Nikos Vassiliadis <nvass@gmx.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
	rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10
MIME-Version: 1.0
To: Adrian Chadd <adrian@freebsd.org>
References: <4F1ABF9C.5010608@gmx.com>
	<CAJ-VmomXDbjj=-8ztjZT-7ODhiRq+z+9PiKfR5i7XOzUjGMvCQ@mail.gmail.com>
In-Reply-To: <CAJ-VmomXDbjj=-8ztjZT-7ODhiRq+z+9PiKfR5i7XOzUjGMvCQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: freebsd-net@freebsd.org
Subject: Re: STP id selection
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Jan 2012 11:47:44 -0000

On 1/22/2012 9:29 AM, Adrian Chadd wrote:
> On 21 January 2012 05:37, Nikos Vassiliadis<nvass@gmx.com>  wrote:
>
>> Hi,
>>
>> The current code in bridgestp.c finds the lower MAC address from all
>> available ethernets and uses it as the STP id. This is problematic when
>> more than one STP bridges participate in the same STP domain because
>> more than one bridges will use the same id. A similar fix was applied
>> to the OpenBSD version of the code[1]. Could you review the attached
>> patch?
>>
>> 1.http://www.openbsd.org/cgi-**bin/cvsweb/src/sys/net/**
>> bridgestp.c?rev=1.33<http://www.openbsd.org/cgi-bin/cvsweb/src/sys/net/bridgestp.c?rev=1.33>
>>
>> Thanks, Nikos
>>
>>
> .. that sounds sensible enough. Sure, please create a PR and then tell me
> what the ID is.
>
> I keep finding myself knee deep in the bridge code so this is something I
> can test out locally.
>

Here it is:
http://www.freebsd.org/cgi/query-pr.cgi?pr=164369

Thanks for looking into this,

Nikos