From owner-svn-src-head@freebsd.org Tue Sep 3 14:06:37 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E98C4DCB12; Tue, 3 Sep 2019 14:06:32 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zX3bZmz4Pfh; Tue, 3 Sep 2019 14:06:32 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 5BE291A802; Tue, 3 Sep 2019 14:06:11 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 730311D412; Tue, 9 Apr 2019 16:18:16 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CD676C9B4; Tue, 9 Apr 2019 16:18:15 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 0B20C1D340; Tue, 9 Apr 2019 16:18:15 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id C342C1D32F for ; Tue, 9 Apr 2019 16:18:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5B74E6C996 for ; Tue, 9 Apr 2019 16:18:12 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1554826684; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=iX5NFjfowltuX2C0TDGQf2Rue+O1JJLniThh0FckK0hzaliKBqvJ7675OdAq/8FOni4jD5iPHF/pq g0I34tJBCzaHkcl6Q5AgwW7LThyk2vh1WTQKis1LigOGDfJsZ3q5psj/lEnRJMpO78WP3MHiAxYGNH 95Lr2Dqy5a0dYGhiXiQ+QVVLF047MDNfsfipEXzL7ilNrE6mme6T8+aqH3PArlgjk9RoONKwf/AK77 KyRXrxGpHQTOW06EH0evllbabWqMzmAWo1UoFpQwgGv40WDBxEaYI5AJR5ZkdHnrdHpHz1Ph2xGt6t s6DI3jQoptjhxiJptDhMm3AYR7h8ZBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=WzuN1Wvec35b2nuIbtCHqGdP5K2KjeoRb+NXPR3L4NA=; b=Z1wu4n0KFnA+qRIHTXU2X1R9MjusWe32BMO/jV68L6RKKfkTsdXlBOl6N2+A2LGzeCDIA0jyO6uZ5 I8jl8m+YictPzpaQfWkUqPFpDg45x/SNkuzdKg4V73HfppIvSfDjIlBFJsJ2770ocee7aCwuU/CKUD Ud2/r3v+QaEQMdbS9aYhfKhalXprwEiojEXPDIUADugKJaQep7jS3weB0mm2WUbgJInGkZfX+sC4Fw h5SM+2lpxZOJ4TUDXifoz8ZrS1PSXMZ6PtXlZgxheRF3nkMyfBJ7rTkxpYZ7orO8k0Nu2n5T8Lkb1Y 6pzKjY/qKvvGPKc/l3Cw39mvKXQaa6w== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=WzuN1Wvec35b2nuIbtCHqGdP5K2KjeoRb+NXPR3L4NA=; b=ovRsmhwV5IZTHP9LJ21ihx64Pj4KpanmkcEztUKgt7VvCCX8G2/5rVTW6KjzJY44/RQmLDtoR/Foi X80Gj9DqYO/WSDQVG73tLEa0CRyF+JtMgQEuOnz4VWNZbJo11IFjJqmgFQW1GjXAWXIJ21+aAm49wC IZexIFV9RWJLXKbZzpOEgR9S5xPYXw1wkp6Da1uSsPDpJVpG43jZ2qXuu9GtckD1R7r5MrY4cGxMgC Fn0ekcqM0lNHVjSA2Ld9Vbz1B9Cc7nEE7ESBroH+7jXCYuDxFxoUFt3jfqceHM6pS5eQFewc8Ecky0 vZWGb3GyJDlZ0AK3gSa6F/MM5EqS23A== X-MHO-RoutePath: aGlwcGll X-MHO-User: 0a87784c-5ae3-11e9-908b-352056dbf2de X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id 0a87784c-5ae3-11e9-908b-352056dbf2de; Tue, 09 Apr 2019 16:18:00 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x39GHw56017970; Tue, 9 Apr 2019 10:17:58 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r346052 - head/sys/dev/usb/net From: Ian Lepore To: John Baldwin , Ganbold Tsagaankhuu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: References: <201904091354.x39Ds9e6070857@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 6CD676C9B4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:37 -0000 X-Original-Date: Tue, 09 Apr 2019 10:17:58 -0600 X-List-Received-Date: Tue, 03 Sep 2019 14:06:37 -0000 On Tue, 2019-04-09 at 09:11 -0700, John Baldwin wrote: > On 4/9/19 6:54 AM, Ganbold Tsagaankhuu wrote: > > Author: ganbold > > Date: Tue Apr 9 13:54:08 2019 > > New Revision: 346052 > > URL: https://svnweb.freebsd.org/changeset/base/346052 > > > > Log: > > In some cases like NanoPI R1, its second USB ethernet > > RTL8152 (chip version URE_CHIP_VER_4C10) doesn't > > have hardwired MAC address, in other words, it is all zeros. > > This commit fixes it by setting random MAC address > > when MAC address is all zeros. > > > > Reviewed by: kevlo > > Differential Revision: https://reviews.freebsd.org/D19856 > > It would be best to not use a purely random mac address and to use > the > function kevans@ added recently. That function generates a MAC > address > from the FreeBSD OUI using a cryptographic hash so you get a > stable address across boots on a given host. > How could that possibly work? If it's not random, you can't have two such devices on the same network. If it is random, it's not stable from one boot to the next. -- Ian