From owner-freebsd-ppc@freebsd.org Tue Aug 28 17:56:52 2018 Return-Path: Delivered-To: freebsd-ppc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42B7E1092C79 for ; Tue, 28 Aug 2018 17:56:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C15E88EB99 for ; Tue, 28 Aug 2018 17:56:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x236.google.com with SMTP id e14-v6so3942615itf.1 for ; Tue, 28 Aug 2018 10:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PTJ/1gAnp0XEtKVKbURYiOLuh0/VEkNWiiys7n3wvco=; b=TAZC/WBTsmsDStUIpVPNgkV5ImdmrP3T0t37Ptk2SlU0blLIigP7/ZTy4geQZBp4/b uZWMp0Wp7DB+fe8pkqjW3+cGyeLTld3nULOgeIF7luhzyxRZQPmZTjT1trDyr70rfm9h F9XLU2OSkKRnatE59T0jN3tTeIqnyQDTcQZZuix1doYsL0IoeqsCP+j1zaJVq0z0KRGh tzPYb0GiUR+2pj7z/yGkhIlBVNTFvylosOLlHzBtpl63RxWDXQBQAfsFfCtzoCP5ZA8q /xDZ4CjLpHtvby7YwHcHs3Tf/Xb+hBRMJV/MecfQauLLvia847q6mzxqP2NeImGui+6a 40Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PTJ/1gAnp0XEtKVKbURYiOLuh0/VEkNWiiys7n3wvco=; b=pilWY7v0FmLNQ1pc/JGuMRwAHrdRyx2rEll9OGgsPKrH7XIIYEYNNfTMz3vjHDMCft o0t7z/sAOYpc4KW+oPF/YmlHdd1Jt2PLdI8ZWZDU9yiRPrdrmZ/l3sQWxaZ/C53JoDeN nCW/rnz7R8TarOk/7q7A8kpkziTZuBn9oRA8PSiPPk9Fjla48CL0DFFE5V/cbF/QkGYV 0Q2tgAn0Eou8lnXrnVoFzu/iLusDDNdRAlAJQTlx+TV+Xh7bj9YT8ot8B0HHitDTpisj 3il+8MxuinyExUDNN1D/pG/v/FgA78pv/HUctqPLcT0Zl1F05rrBziXkhLRXO2sOrqwd 8f+w== X-Gm-Message-State: APzg51Az5Fk7sEDP4/EUL5AbV2uoPCDmfJXaSSZ6DK2uCGIZf/OeZm5i DhBWcuJq1s+tjkta1BiA6c5L9twNPup2Zmg+dCY7FCRqRVs= X-Google-Smtp-Source: ANB0VdZBGVGCwcNxe2Md/w/urvmGipDPUuyFiYd48Plt3XhXQ9QqLf8tvwnKwKD+mBRWmjg8Wk89wedMtPVU+CZNXxQ= X-Received: by 2002:a24:c902:: with SMTP id h2-v6mr2489455itg.75.1535479010577; Tue, 28 Aug 2018 10:56:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Tue, 28 Aug 2018 11:56:39 -0600 Message-ID: Subject: Re: svn commit: r338348 - in head/sys/dev: drm drm2 To: Kevin Bowling Cc: Mark Millard , Warner Losh , svn-src-head@freebsd.org, FreeBSD PowerPC ML Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2018 17:56:52 -0000 Your comments weren't exactly clear in the review (even after clarification), and they were at odds with what I'd been told, I thought, the graphics folks wanted to message: all 64-bit platforms use drm-stable/drm-devel. Warner On Tue, Aug 28, 2018 at 11:51 AM Kevin Bowling wrote: > Legacy would be needed by existing these existing ppc64 at the moment > and I pointed out in the review that LP64 is not the correct heuristic > but was dismissed without understanding the point. > > On Tue, Aug 28, 2018 at 10:36 AM, Mark Millard via svn-src-head > wrote: > > For the below I wonder if graphics/drm-stable-kmod > > would be correct for old powerpc64 PowerMac's and > > such. > > > > Presuming graphics/drm-legacy-kmod (I do not know): > > Tier 2, old equipment, etc. so it may just be an item > > for handling questions on the lists rather than making > > a mess instead of the below to cover sufficient > > alternatives. > > > >> Modified: head/sys/dev/drm2/drm_os_freebsd.h > >> > ============================================================================== > >> --- head/sys/dev/drm2/drm_os_freebsd.h Tue Aug 28 14:46:49 2018 > (r338347) > >> +++ head/sys/dev/drm2/drm_os_freebsd.h Tue Aug 28 14:46:55 2018 > (r338348) > >> @@ -154,6 +154,20 @@ typedef void irqreturn_t; > >> *(volatile u_int64_t *)(((vm_offset_t)(map)->handle) + \ > >> (vm_offset_t)(offset)) = htole64(val) > >> > >> +#ifdef __LP64__ > >> +#define DRM_PORT "graphics/drm-stable-kmod" > >> +#else > >> +#define DRM_PORT "graphics/drm-legacy-kmod" > >> +#endif > >> + > >> +#define DRM_OBSOLETE(dev) > \ > >> + do { > \ > >> + device_printf(dev, > "=======================================================\n"); \ > >> + device_printf(dev, "This code is obsolete abandonware. Install > the " DRM_PORT " pkg\n"); \ > >> + device_printf(dev, > "=======================================================\n"); \ > >> + gone_in_dev(dev, 13, "drm2 drivers"); > \ > >> + } while (0) > >> + > >> /* DRM_READMEMORYBARRIER() prevents reordering of reads. > >> * DRM_WRITEMEMORYBARRIER() prevents reordering of writes. > >> * DRM_MEMORYBARRIER() prevents reordering of reads and writes. > > > > > > === > > Mark Millard > > marklmi at yahoo.com > > ( dsl-only.net went > > away in early 2018-Mar) > > > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >