From owner-svn-src-svnadmin@freebsd.org  Thu Aug  6 18:19:31 2015
Return-Path: <owner-svn-src-svnadmin@freebsd.org>
Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E320B9B59C6;
 Thu,  6 Aug 2015 18:19:31 +0000 (UTC)
 (envelope-from peter@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BAC0A118B;
 Thu,  6 Aug 2015 18:19:31 +0000 (UTC)
 (envelope-from peter@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.70])
 by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t76IJVxO060184;
 Thu, 6 Aug 2015 18:19:31 GMT (envelope-from peter@FreeBSD.org)
Received: (from peter@localhost)
 by repo.freebsd.org (8.14.9/8.14.9/Submit) id t76IJVKV060183;
 Thu, 6 Aug 2015 18:19:31 GMT (envelope-from peter@FreeBSD.org)
Message-Id: <201508061819.t76IJVKV060183@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: peter set sender to
 peter@FreeBSD.org using -f
From: Peter Wemm <peter@FreeBSD.org>
Date: Thu, 6 Aug 2015 18:19:31 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-svnadmin@freebsd.org
Subject: svn commit: r286377 - svnadmin/hooks/scripts
X-SVN-Group: svnadmin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-svnadmin@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the admin / configuration tree
 <svn-src-svnadmin.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-svnadmin>, 
 <mailto:svn-src-svnadmin-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-svnadmin/>
List-Post: <mailto:svn-src-svnadmin@freebsd.org>
List-Help: <mailto:svn-src-svnadmin-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-svnadmin>, 
 <mailto:svn-src-svnadmin-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Aug 2015 18:19:32 -0000

Author: peter
Date: Thu Aug  6 18:19:30 2015
New Revision: 286377
URL: https://svnweb.freebsd.org/changeset/base/286377

Log:
  Check for some specific forms of broken commit templates.

Added:
  svnadmin/hooks/scripts/stomp_bad_formatting.pl   (contents, props changed)

Added: svnadmin/hooks/scripts/stomp_bad_formatting.pl
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ svnadmin/hooks/scripts/stomp_bad_formatting.pl	Thu Aug  6 18:19:30 2015	(r286377)
@@ -0,0 +1,54 @@
+#!/usr/bin/perl -w
+#
+# $FreeBSD$
+
+use strict;
+my $debug = 0;
+
+# $ svnlook changed /home/svnmirror/base -r 12348
+# UU  head/sbin/mountd/mountd.c
+# UU  head/usr.sbin/mountd/mountd.c
+# $ svnlook log /home/svnmirror/base -r 12348
+# Avoid bogus free() of a junk pointer.
+#
+# Detected by: phkmalloc
+# Submitted by:   grog@lemis.de (Greg Lehey)
+#
+# Except that when called to vette a commit, it'll be "-t txn", not "-r rev"
+
+
+my $repo = $ARGV[0];
+my $txn = $ARGV[1];
+
+my $log = "";
+
+open(LOG, "svnlook log $repo -t $txn |") || die "cannot open svnlook log: $!";
+foreach (<LOG>) {
+	print "$$: log: $_" if ($debug);
+	$log .= $_;
+}
+close(LOG);
+
+if (stomp_bad_formatting($log)) {
+	exit 1;
+}
+exit 0;
+
+# ============================================================
+# Look for a few specific mangled/broken template cases as a
+# stopgap for checking for a proper template.
+
+sub stomp_bad_formatting {
+	my ($log) = @_;
+	my $rv = 0;
+	if ($log =~ m|\n\nReviewers:[\t ]+|s) {
+		printf STDERR "**** Non-standard/badly formatted template - found 'Reviewers:' instead of 'Reviewed by:'.\n";
+		$rv = 1;
+	}
+	# There is really no need for this spam in log messages.
+	if ($log =~ m|\n\nSubscribers:[\t ]+|s) {
+		printf STDERR "**** Non-standard/badly formatted template - found 'Subscribers:'.\n";
+		$rv = 1;
+	}
+	$rv;
+}