From nobody Tue Apr 21 11:32:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g0KwR0nP7z6bfGm for ; Tue, 21 Apr 2026 11:32:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g0KwQ3zF2z3XDP for ; Tue, 21 Apr 2026 11:32:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776771174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nJ/d105KEmVGbt9CHIKfz7rJ2ilwa+g1wjg9dKFmbOc=; b=GZB8HdKykWPFugVH8fAhaANLmvac3DLY9PXWZZp3qFzj78vWf3einw9y3IDCFZN4natSeY kuBf8NfuXvkdV6fZvsbUXjBfD3xGHl/jn44hk+TXXa2qlFaWPkjJu/CTcGA9K+3BCm8H/Q BBDh4bieVPXcDKnHrCoTISzLKkapGfV8G41f1jKTQ/RjmKlG79GjUDrN2sn/dusE3YDuYL SxdhfF2oTNzztrpGs8QioBr2nEyitQXYtlqR2TuzF4+vuO4aHVETcOiMkp1tRYczqgo8IG l946OJxEJl3E4soI0Svq+1FdVgQkG/UehTiSklt9yGZq+IlbhpeVC/7JzARN+w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776771174; a=rsa-sha256; cv=none; b=ci60G2+d+GZQRl8q43oeXgHU7VJuBpi5wDSnknM+UkvvlYrMeFY+cNimQqoIRGAQ3GF2I3 /GHqy/KlifhkYk48Ihg3thWoWljV+BxtnBc+ey+OTh12/cokH/O82B1sZT6ua75MVuGUgm 7kU1TfuGKX1tDksa2LiiqvM5ybRSFjTEHdiWx00OtdPjc4nCBJxAB3WHOl/mEaNyxFfHCd FICk1mU+zQyrIlRzj6CLUvo6N+5NKh0FYWunmkxWYCrwvVa2cyW6adN4S1q8Lnkk2p2+Vp SDSOJd05Um1gGKHAReHsXLrP8xYKkam2QzsGcxFrJerTdjdilwXUQfytiPOTwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776771174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nJ/d105KEmVGbt9CHIKfz7rJ2ilwa+g1wjg9dKFmbOc=; b=Y+ZnUl2GngNTQTtRWpVlO5i4PxeOq5kJEloKVhCZvzqaMW0GjZE+8QxQRETfNeY52LIDE9 yE5sx8BZxUoTzm0QMPtpkoHOyPkIcaebSQeB4F/Y8cbO4DLVPJSdyzn64lmwgBqg9bnjt4 a2XrxnNXFq8T1l5qyz1i3RieGyQKEk3cR+n+umsAiFDzx7nOVg+BTjH7aySh//O4QYvvPw 4d7gfB2Tkm2EdKojR0DsEyRhoqWTdE0sHq4Tj0yIO3D/oA+o4DIh3luZE5yKbk8QOEjlwI rFJd4wfvjiCXXDU7f2YUmpRA7vzgyqvrg58GUwJpJeETT6C5Ama4w669S6CHlA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g0KwQ0662zjPK for ; Tue, 21 Apr 2026 11:32:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 409e4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 21 Apr 2026 11:32:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 07a3501e6c85 - main - loopback: fix use-after-free List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 07a3501e6c85baa4236061f8af4c2772307835f4 Auto-Submitted: auto-generated Date: Tue, 21 Apr 2026 11:32:54 +0000 Message-Id: <69e76066.409e4.11f83ddd@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=07a3501e6c85baa4236061f8af4c2772307835f4 commit 07a3501e6c85baa4236061f8af4c2772307835f4 Author: Kristof Provost AuthorDate: 2026-04-21 09:19:26 +0000 Commit: Kristof Provost CommitDate: 2026-04-21 09:51:29 +0000 loopback: fix use-after-free Once we hand an mbuf over to netisr_queue() we may no longer access it. Save the length before the call so we can use it to increment counters afterwards. Fixes: 956acdce0505 ("loopback: Account for packet drops") Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/net/if_loop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/net/if_loop.c b/sys/net/if_loop.c index 2ff265d5d1e7..33ddd3a8540e 100644 --- a/sys/net/if_loop.c +++ b/sys/net/if_loop.c @@ -276,6 +276,7 @@ int if_simloop(struct ifnet *ifp, struct mbuf *m, int af, int hlen) { int isr; + int32_t len; M_ASSERTPKTHDR(m); m_tag_delete_nonpersistent(m); @@ -350,9 +351,10 @@ if_simloop(struct ifnet *ifp, struct mbuf *m, int af, int hlen) m_freem(m); return (EAFNOSUPPORT); } + len = m->m_pkthdr.len; if (netisr_queue(isr, m) == 0) { if_inc_counter(ifp, IFCOUNTER_IPACKETS, 1); - if_inc_counter(ifp, IFCOUNTER_IBYTES, m->m_pkthdr.len); + if_inc_counter(ifp, IFCOUNTER_IBYTES, len); } else { /* mbuf is free'd on failure. */ if_inc_counter(ifp, IFCOUNTER_IQDROPS, 1);