From owner-svn-ports-all@freebsd.org Sat May 28 19:54:42 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17CD0B4EDE0; Sat, 28 May 2016 19:54:42 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CC2A11252; Sat, 28 May 2016 19:54:41 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 9AB34BDC70; Sat, 28 May 2016 21:54:39 +0200 (CEST) Received: from atuin.in.mat.cc (AAmiens-654-1-80-87.w92-142.abo.wanadoo.fr [92.142.245.87]) by prod2.absolight.net (Postfix) with ESMTPA id 6BB4DBDC66; Sat, 28 May 2016 21:54:39 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id A35BD613A257; Sat, 28 May 2016 21:54:38 +0200 (CEST) Date: Sat, 28 May 2016 21:54:38 +0200 From: Mathieu Arnold To: Kurt Jaeger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416053 - head/Mk/Uses Message-ID: <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc> In-Reply-To: <201605281719.u4SHJiAa008852@repo.freebsd.org> References: <201605281719.u4SHJiAa008852@repo.freebsd.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="==========6F8657D563B743C20E3F==========" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 May 2016 19:54:42 -0000 --==========6F8657D563B743C20E3F========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 28 mai 2016 17:19:44 +0000 Kurt Jaeger wrote: | Log: | Mk/Uses/qmake.mk: add empty do-configure target I'm going to pass on the commit message. | .if !target(do-configure) && ! ${qmake_ARGS:M_env} | -_USES_configure+= 450:qmake-configure | +do-configure: qmake-configure | + @${DO_NADA} | .endif I should explain a bit more. This goes against the Right Way Of Doing Things(c)(r)(tm). To add a target to be run in the targets pipeline, you use _USES_xxx, you never, ever, piggyback on an existing target, especially if you're not using it. So, please, back this out. -- Mathieu Arnold --==========6F8657D563B743C20E3F========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJXSfd+XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I8uMP/jHCj9TVLzgKVwzDA6peKaSc OyfJ+sWpOS7BVYXupjUoFqfVUqpTopTw4CYZLiTHYh7kpMjjY4pqWiunhd8HsPbc XTZ4t7B/HmRfh1d9xEMnETsC/vq5xW9zDzgy0KnPN/0q9RVEdXodPSu/IVwD01tg FDReTnxjCjliNraFYxxI7Corsm8qj4N72E8XdDi4oSFrmcMQMRfMjzy2yN7J7oK4 m88LwZK938raq2r+teNWTPHIVe8UAf1RemIU+Z+zDSklNJQu/tmVkMzqDpCbPqoo gRAxwO/4mH77rpgNjA99+zSSfFL7S7t60NdRfzS8AkSUzE4ecFXLilPi2J9LVauD Kdy90HBQjIyvMtgmT9YPxSi/HDXTtltyUDZUXyajv/3CkU1cB3ObVP9Yvp4/X8Rg LrxUJnxMt3Pd9tkwDvL6w7zRfQiuU2X4bfYv0tsDNqUDqFWwAYpkHtOwD7/md1a7 FZ6gmAogQzCAemfujRp8y/vdk4uVqF7QS+c16ZVPvHDL3MJpmcy6NdW5lu0IlmkG yG2X4Deg5Ia09Wg6YPhFwolPOS4RFk/EA98VWjjpHp2lE7WzGHJQdQyGNsmBdZPn YXwixLII2wVZmcaPQhrUnChw7naY7UI6q971z1hKi31IPlt+RIf7lrS024/OhGxP yhJjTKNIJ2MX7FCe/Z30 =9gkp -----END PGP SIGNATURE----- --==========6F8657D563B743C20E3F==========--