From owner-svn-src-all@freebsd.org Fri Sep 23 23:09:10 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18E8FBE65BA; Fri, 23 Sep 2016 23:09:10 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B1A091972; Fri, 23 Sep 2016 23:09:09 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id b184so4845244wma.3; Fri, 23 Sep 2016 16:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RD1XVFE9CJmYH8i5PCeLcYz1gh4TTQS9+0GXye3DHjo=; b=VE4PFPguYZaTiTLBAgSmgxFVNKaxzS3cw21X0p0LkXtOaPsl/wc9u4Z7FFVJUSC7sq 9XxH2LH+EModgPBtl3HXcw/UIo50gZ8t+leQxo6M29yASkcNd675ETTJ5BJV+gMaQaJo jTu4sTVAqdJ0cG2Mr97eixM4X5spQN4diAkNAPv0vlF9Ud56WgCI9v0pk40A27glxB4L RBJpr6uyB7/65GaPPH6CsuoN9fb0mCEdnJXOPttjZQNz739l/5WDMCVhzavn8mi6eF2N 7albz3Mi0jVZl0Zs8rlZna9HC9PYbzWuwt5bWkUfrAkQXgRQNOextsJtyR51m5HxNZo8 XGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RD1XVFE9CJmYH8i5PCeLcYz1gh4TTQS9+0GXye3DHjo=; b=LSY59q5W+nF5Ddit9w2bbROm9ywUCmO4b3EM3epmAyrO4Y9aRy5zqNxQJJMEDYdwva 1nh2S7l85WzhJbPusfQqUiH6l1MF5N4kjJ47jG1SO2pDprtbGEnULXaeBWq0Hdx8b6lU k+w+p/uirBblSCAP+jgfsXT3dXQhutBi0AItaAVFr7C3/KWsv7nlFu+1aDou3QVApP6A kDKkDHE/oOHlL/MfGT+WrpW03mAecg69Mh/s5sz9tBtS0Eo+8UW2KA47FW37NUpyRzzp b93IwBGjG+7ZNvpLIgF1NGQ7bk26RzpHB9AwRJeUMJL5y/ULZFYKVhLeApUlDLlCBV5h FH2Q== X-Gm-Message-State: AE9vXwOTI2Mhz58VyJhp+YzwNoGJKSil/K2A+oeuvI40kORsudh7m8AOUmRiQg+356YtSQ== X-Received: by 10.194.81.106 with SMTP id z10mr8748488wjx.140.1474672147079; Fri, 23 Sep 2016 16:09:07 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id ya1sm9382843wjb.23.2016.09.23.16.09.06 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 23 Sep 2016 16:09:06 -0700 (PDT) Date: Sat, 24 Sep 2016 01:09:04 +0200 From: Mateusz Guzik To: Andreas Tobler Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306272 - head/sys/sys Message-ID: <20160923230904.GC25423@dft-labs.eu> References: <201609231647.u8NGlCYF045234@repo.freebsd.org> <20160923200308.GB25423@dft-labs.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 23:09:10 -0000 On Fri, Sep 23, 2016 at 10:38:05PM +0200, Andreas Tobler wrote: > On 23.09.16 22:03, Mateusz Guzik wrote: > >On Fri, Sep 23, 2016 at 09:59:32PM +0200, Andreas Tobler wrote: > >>On 23.09.16 18:47, Mateusz Guzik wrote: > >>>Author: mjg > >>>Date: Fri Sep 23 16:47:12 2016 > >>>New Revision: 306272 > >>>URL: https://svnweb.freebsd.org/changeset/base/306272 > >>> > >>>Log: > >>> fd: hide fd_modified under CAPABILITIES > >>> > >>> It has no use without it and is now less error prone. > >>> > >>>Modified: > >>> head/sys/sys/filedesc.h > >>> > >>>Modified: head/sys/sys/filedesc.h > >>>============================================================================== > >>>--- head/sys/sys/filedesc.h Fri Sep 23 16:22:03 2016 (r306271) > >>>+++ head/sys/sys/filedesc.h Fri Sep 23 16:47:12 2016 (r306272) > >>>@@ -229,12 +229,14 @@ fdeget_locked(struct filedesc *fdp, int > >>> return (fde); > >>>} > >>> > >>>+#ifdef CAPABILITIES > >>>static __inline bool > >>>fd_modified(struct filedesc *fdp, int fd, seq_t seq) > >>>{ > >>> > >>> return (!seq_consistent(fd_seq(fdp->fd_files, fd), seq)); > >>>} > >>>+#endif > >>> > >>>/* cdir/rdir/jdir manipulation functions. */ > >>>void pwd_chdir(struct thread *td, struct vnode *vp); > >> > >>I think this breaks kernel builds: > >> > >>/usr/src/sys/modules/cloudabi/../../compat/cloudabi/cloudabi_fd.c:482:14: > >>error: implicit declaration of function 'fd_modified' is invalid in > >>C99 [-Werror,-Wimplicit-function-declaration] > >> modified = fd_modified(fdp, uap->fd, seq); > >> ^ > >>1 error generated. > >>*** [cloudabi_fd.o] Error code 1 > >> > > > >Ye indeed, I hacked up a fix: > >https://people.freebsd.org/~mjg/patches/cloudabi-fd_modified.diff > > > >if ed@ does not respond soon acking the patch, I'll temporarily reviert > >this change. > > > > Thanks, I reverted locally to continue my work. So no hurry. > Fixed in r306282. -- Mateusz Guzik