From owner-freebsd-current@freebsd.org Mon Dec 16 22:27:26 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DDFE81D0346 for ; Mon, 16 Dec 2019 22:27:26 +0000 (UTC) (envelope-from nomadlogic@gmail.com) Received: from mail-vk1-xa42.google.com (mail-vk1-xa42.google.com [IPv6:2607:f8b0:4864:20::a42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cG9T6Tsqz4PXT for ; Mon, 16 Dec 2019 22:27:25 +0000 (UTC) (envelope-from nomadlogic@gmail.com) Received: by mail-vk1-xa42.google.com with SMTP id b129so1388920vka.4 for ; Mon, 16 Dec 2019 14:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=6gtXzHW1o3rU4F+AVHO1eAlZoAPiUklCUQ9IBS5h1jQ=; b=Qb8WMh9gYfn7Ub1EDL00JxDl5eBEr6rYXlDQ0YskXkSWhyj8k+WWjLl7bZ9iduTcNX DC/T255xg0FApiXxbGP4FWbIV1sqZxHQc4O3P0Pp7UPlBixOz0IeWsvk+2yzbnm150IK MCjO0MZ6laXML6g8EsV2Cq0tIBnXG2NCLpmYJ+5TXpOwkAX3JwgHmmr8RgPrCAmuQnKv fiOc0lyUUsFWV4Ka0vu95fUjsdStc/xrTx6k8mK1koLZdqIygyow3OwAMwQsC1o6Y/9N pumiMpL3XyzkQ23S8RHdS/D6yVvtfTUU4NhCarSOO6Uv/V2hVx22EXkVVTrhiRfTMZiX 5OsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=6gtXzHW1o3rU4F+AVHO1eAlZoAPiUklCUQ9IBS5h1jQ=; b=MqknWpejtiwwb1TcnabqJFQPIGlqSz4dcdOgbYgW3RorxrnkXncH8MRrg2tmjYY1g+ T0HRbR9vsq+E1ldmZ0ecfFQ/beuq5sB0x0RjW9KotAvpxN3cAt3d3rfNrcnOdD93B1mn II7g2++cYtwBEOkTZSr8gyn0t3IhvPcbO+flWJUBdK7suXeJ8d3ahzHoYm1siMjyHoFv rqyCywViN30VrovJ/CE35JKmy2mMqiPBcaE+Cxz+Uwu9ejsJLtprpposltTcDek2/60v wVjmajmLJ+VOK+/n223syMKWKMLZRFI5uq/hG/7OYpLhZ/2qqcNM7aZ6/iOflJUT2I7O eCew== X-Gm-Message-State: APjAAAXqkVwNvsiRq5JYT2elzYHSVWucyHP62rl4VlTW6/sMOkfjmYwW AbxJfqEpkDL97vA3PWQEr/IkJTj89cxaWfeY3jgcL5+0 X-Google-Smtp-Source: APXvYqx/tdiiYVTyJSeCL8M0zLUnpWf8mWM3Jta4FzhJjTmxbjOZjNLyXj3CldSz740Ls1BUm1sjZR9NZoylaplqX2o= X-Received: by 2002:ac5:c64c:: with SMTP id j12mr1045015vkl.11.1576535243763; Mon, 16 Dec 2019 14:27:23 -0800 (PST) MIME-Version: 1.0 From: pete wright Date: Mon, 16 Dec 2019 14:27:12 -0800 Message-ID: Subject: error building scsi_da.c with recent current To: freebsd-current@freebsd.org X-Rspamd-Queue-Id: 47cG9T6Tsqz4PXT X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Qb8WMh9g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of nomadlogic@gmail.com designates 2607:f8b0:4864:20::a42 as permitted sender) smtp.mailfrom=nomadlogic@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(0.00)[ip: (2.08), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2.4.a.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 22:27:26 -0000 here's the error i'm getting when building: /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:28: error: expected identifier SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, ^ /usr/home/pete/git/freebsd/sys/sys/sysctl.h:126:18: note: expanded from macro 'OID_AUTO' #define OID_AUTO (-1) ^ /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:1: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, ^ /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:13: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, ^ 3 errors generated. *** [scsi_da.o] Error code 1 might be this commit? commit 5fa79c6768be78d78815156f8ecf50cb2008233f (HEAD -> master, origin/master, origin/HEAD) Author: imp Date: Mon Dec 16 18:16:44 2019 +0000 Implement a system-wide limit or da and ada devices for delete. Excesively large TRIMs can result in timeouts, which cause big problems. Limit trims to 1GB to mititgate these issues. Reviewed by: scottl Differential Revision: https://reviews.freebsd.org/D22809 if there is any additional info needed happy to provide it. cheers, -pete -- pete wright www.nomadlogic.org @nomadlogicLA