Date: Mon, 8 Apr 2002 17:21:11 -0700 (PDT) From: Adam Migus <amigus@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 9413 for review Message-ID: <200204090021.g390LBI19321@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=9413 Change 9413 by amigus@amigus_ganyopa on 2002/04/08 17:20:55 Oops. Forgot to test and properly handle when user declares an interface name with strlen() > IFNAMSIZ. Affected files ... ... //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#27 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#27 (text+ko) ==== @@ -465,20 +465,22 @@ else len = strlen(p0); - if (len > IFNAMSIZ) { + if (len <= IFNAMSIZ) { + strncpy(tifr_name, p0, len); + if (!strncmp(tifr_name, ifr_name, len) && + len == strlen(ifr_name)) { + trusted_interface = 1; + break; + } + } else if (len == 0) { + break; + } else { if (p1) *p1 = '\0'; - printf("%s: name exceeds maximum length\n", p0); + printf("%s: interface name exceeds IFNAMSIZ (%d)\n", + p0, IFNAMSIZ); if (p1) *p1 = ','; - } else if (len == 0) - break; - - strncpy(tifr_name, p0, len); - if (!strncmp(tifr_name, ifr_name, len) && - len == strlen(ifr_name)) { - trusted_interface = 1; - break; } if (p1 == NULL) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204090021.g390LBI19321>