From owner-svn-src-stable-12@freebsd.org Thu Jul 30 07:03:37 2020 Return-Path: Delivered-To: svn-src-stable-12@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 876DB37B021; Thu, 30 Jul 2020 07:03:37 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-qb1can01on061b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5c::61b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BHLwn1FmCz3bV8; Thu, 30 Jul 2020 07:03:36 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qo1EwlOZ5PnH/k6QrqjqHomS4tnWVaqijJrVH9pktwxNm1L0AZxH82fKE/Vyj/jF9RZNJat9sjVKFT25Iij5QYwhIqDagthh79tuVtn2xFJx3iR9oCDN2IXXKfv3+XqNR+xPzVP/PGbapL4k0zpMMJvKB5JbwWJ72EjE1qNiXHHjvHd2TtfXwsg6fiytAmdx1AYsLcIP77Zu1MAbk4R6ubsTZehzwgBkCfSweKyFbDtYdB2NOdEqgwitKaGSWdujOxSwvqcPHlcjIPolUE7xn2kkylZrn6I99T/b4s/TVp+M8Fb2sGA2FTpjf/++wluSzhDj7TZO1NyE1w4znGfqGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GUH7hEdbcCkO9sDeuQUJywSt9df2IgZBiathivs8GYw=; b=MOt/0HPugDVe8i2XWAWXBrx/M0eiHzwTw3eWD66xy1o3284HPNpX2Duqjx4iPAs0ychfI8uk3Tsw1o8rLwK79y4hX425ug7wYd/cRHLZeLPCfVBCWf8qjFIZuf+L4Gk1KAzDVFdCsqyapaxjwwKGwUci8ayY/52htZQhgaSOvbPNHESwixFrBQf/WX6nnSw5ByJgULpWsP6AHwN0ibVJSxWdz2cz2juQNsZE7UyKbYE/vLZO9JdsEwhR3Q84SuXpGD2OqnYkI0bz0o88CWCeTcPW5YG/L7xypCLPovWD9nH+siid/JPwEUsjyVHO/DWbn4cW0Ry9Q0zQeO7UegHEew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GUH7hEdbcCkO9sDeuQUJywSt9df2IgZBiathivs8GYw=; b=kgNxKcoqsF0XdHZiuNvkyCtG/Lfwfl8CjqCCYFhcnR6Cln60MIO/5NRNR3dX83qhPcq7Ord8VuRkaRA4HNSdcGCmJj39Jqw8FlHB3OkEpHT7Uid3X23lcyIsj+hRDNS+dQ534E9RVihhVukNLToii7KV/cw9stRFkNqA0xwFGg0gb0ClfTOUDeDG9g2MmQH3CSJjD8/bBkshCrcqbm0BgAO8tS9O+Zf9V9uLheLEKH8Xt78jFCD/dGNoZSWH6xHP16ogwsV1lgTG6zf1eJ259UElG7mEfuvR9UQBgVExazboFB9ZG8HwHUhdTnVD0NxxXmVkTefrFs+5vGCcpPwUEg== Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:38::14) by YQXPR0101MB2007.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:1a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Thu, 30 Jul 2020 07:03:34 +0000 Received: from QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::60f3:4ca2:8a4a:1e91]) by QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM ([fe80::60f3:4ca2:8a4a:1e91%7]) with mapi id 15.20.3216.033; Thu, 30 Jul 2020 07:03:27 +0000 From: Rick Macklem To: Ian Lepore , Brooks Davis , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-12@freebsd.org" Subject: Re: svn commit: r363625 - stable/12/usr.sbin/mountd Thread-Topic: svn commit: r363625 - stable/12/usr.sbin/mountd Thread-Index: AQHWZGw7l3AA2GANGkmYHY+WWlMRT6kfVzKsgAAiMQCAADpv4g== Date: Thu, 30 Jul 2020 07:03:27 +0000 Message-ID: References: <202007272318.06RNIFjV005206@repo.freebsd.org> , <4d5b871fad9412661c3914a64c8ca0b7a01d1dc6.camel@freebsd.org> In-Reply-To: <4d5b871fad9412661c3914a64c8ca0b7a01d1dc6.camel@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa208615-02fc-4811-bee0-08d83456a88a x-ms-traffictypediagnostic: YQXPR0101MB2007: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G2W9MSScjiq2bp31BOUjbgiwqQb5SNEgmCyYOJnR9QlUSetssG2t6pBwkPUepRIYJOKMHHekLQIbNxrsGRoohh4c9djUADXZ0T+yMu/SS2nagEISY0Zme/ysuVyw0gi5Tju3KuJB8i/8uw20cAG0g/792Bx8rC0/0uRrhED4z7zP3aGyJg1sYZ9/5/OmlS7qfjULms2mj7d5rMpvh5qe77xRjz17PV3CLuudH4cI7UHyi5kdPFV05GAQpN31fvxv4aocaasfQ7w/C4hIoHuiQoZpzXs5iLFr8GJ9hqZwG2iWOWF0PIvw9FAIeSChn9sYyKMDBKWZWy+t9FFfbaJR2kitIuRrZT76KUrkRa7fm0HxYgI/Nsmu59nd7FkKeSHnuun8BF9ynicJiOxKi6fq7A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:(136003)(376002)(346002)(366004)(396003)(39860400002)(66476007)(110136005)(2906002)(83380400001)(186003)(66446008)(64756008)(66556008)(5660300002)(52536014)(91956017)(76116006)(66946007)(6506007)(33656002)(86362001)(478600001)(966005)(71200400001)(316002)(786003)(55016002)(7696005)(450100002)(9686003)(8676002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: gu97slwXZKmCjd8PL+cjXA73YghfTJinedCqumZT+9G/R55p164glMNQaSdWr8Qsj3pg9ueHqAD9pCd+TB7F5TDnS5dLFPhN1VcR7tBSMvJuGdW8Y1komJNtMcE5UOi7dFjwiyAO1w2J+gqNfYXVoKM/DwWSO449riVALU+WFE7fADE3q5Ofer+qIXcvYxNI/2xHs5DA/BL8ARxFx0xp1mUr0S3OkOwI5kAblUieTTRaucidAHkUPxarinGvJaX2Tmk02mrXf3aIesIkxa51NnKlrzBVgN4zB3b//u1rg/x9L7dHFo7HtiqzgoTx2a0gmjhwX59dWIikuT1s6iEHG469mu4eJPKAwo7/8An25rdafUtz6Bg6kioLCgnoxmhI9TYzN/GpkW1cxVi9diYYMChyP615VoQBhBf8H+A6J9o7VSmZRJ7hHDA+5e6YFIeYI4exndjUk2h2Bn3l5MwnYcrbsKehCy9/bB5F+ZNrdNp+T2Eyph3uUDZvdVeMM6S1zcR8erM7yNJvXh0D+4hrt9KsKTK7A5KJ3CDdJsoGSOBShOQKwvA7/gYV7MJcU6wF x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: QB1PR01MB3364.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: aa208615-02fc-4811-bee0-08d83456a88a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2020 07:03:27.1282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n23s8LIh9VDW9n5xxO34ubx6tHhy1euP4lr/yFs3nsHBjxhcpZfVRNXn5oni0ICguuZZ1py+o77MamUz+jfXJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR0101MB2007 X-Rspamd-Queue-Id: 4BHLwn1FmCz3bV8 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 07:03:37 -0000 Ian Lepore wrote:=0A= >On Thu, 2020-07-30 at 01:52 +0000, Rick Macklem wrote:=0A= >> Brooks Davis wrote:=0A= >> > Author: brooks=0A= >> > Date: Mon Jul 27 23:18:14 2020=0A= >> > New Revision: 363625=0A= >> > URL: https://svnweb.freebsd.org/changeset/base/363625=0A= >> >=0A= >> > Log:=0A= >> > MFC r363439:=0A= >> >=0A= >> > Correct a type-mismatch between xdr_long and the variable "bad".=0A= >> >=0A= >> > [...]=0A= >> --> I can't see how the xdr.c code would work for a machine that is=0A= >> BIG_ENDIAN and where "long" is 64bits, but we don't have any of=0A= >> those.=0A= >>=0A= >=0A= >mips64 and powerpc64 are both big endian with 64-bit long.=0A= Oops, I didn't know that. In the past, I've run PowerPC and MIPS, but thoug= ht=0A= they both were little endian. (I recall the arches can be run either way.)= =0A= =0A= Anyhow, take a look at head/lib/libc/xdr/xdr.c and it looks to me like it= =0A= has been broken "forever" (ever since we stopped using a K&R compiler=0A= that would have always made "long" 32bits).=0A= =0A= If anyone has either of these and can set up an NFS server on one of=0A= them and then try and do an NFSv3 mount that is not allowed, it would=0A= be interesting to see the packet trace and if the MNT RPC fails, because=0A= it looks like it will put the high order 32bits on the wire and they'll=0A= always be 0?=0A= =0A= Just to clarify. The behaviour wasn't broken by this commit. I just=0A= don't see how the commit fixes anything?=0A= =0A= rick, who doesn't have these arches to test on.=0A= =0A= -- Ian=0A= =0A= =0A= =0A=