From owner-svn-ports-all@FreeBSD.ORG  Fri Oct 18 08:10:56 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 87499DC;
 Fri, 18 Oct 2013 08:10:56 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A8B1A298A;
 Fri, 18 Oct 2013 08:10:55 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.26.50])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id F3881435A3;
 Fri, 18 Oct 2013 03:10:37 -0500 (CDT)
Message-ID: <5260ECEB.70302@marino.st>
Date: Fri, 18 Oct 2013 10:10:19 +0200
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Oliver Lehmann <oliver@freebsd.org>
Subject: Re: svn commit: r330725 - in head/games/heretic: . files
References: <201310180705.r9I75eZV063407@svn.freebsd.org>
 <20131018075408.GI42657@ithaqua.etoilebsd.net>
 <20131018095930.Horde.738PZNGCU9PTyyjPK3vb3g1@avocado.salatschuessel.net>
In-Reply-To: <20131018095930.Horde.738PZNGCU9PTyyjPK3vb3g1@avocado.salatschuessel.net>
X-Enigmail-Version: 1.5.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Oct 2013 08:10:56 -0000

On 10/18/2013 09:59, Oliver Lehmann wrote:
> 
> Baptiste Daroussin <bapt@freebsd.org> wrote:
> 
>> On Fri, Oct 18, 2013 at 07:05:40AM +0000, Oliver Lehmann wrote:
> 
>>> [...]
>>> +-CC = gcc
>>> ++#CC = gcc
>>> [...]
> 
>>
>> Passing CC and CFLAGS to MAKE_ARGS will achieve the same goal without
>> the need
>> of an external patch.
>>
>> MAKE_ARGS= CC="${CC}" CFLAGS="${CFLAGS}"
> 
> Please reread my patch - I snipped it to the important part. ;)
>

Oliver,
As I understand it, the original line only defines CC to "gcc" if CC is
not present in the MAKE_ARGS.  Thus bapt is correct, you don't need to
patch this line.

(In BSD make, it would be CC?=gcc, but gmake looks at MAKE_ARGS)

John