From owner-freebsd-bugs  Fri Jun 19 09:12:19 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id JAA11033
          for freebsd-bugs-outgoing; Fri, 19 Jun 1998 09:12:19 -0700 (PDT)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA10917
          for <freebsd-bugs@FreeBSD.org>; Fri, 19 Jun 1998 09:11:25 -0700 (PDT)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id JAA17761;
	Fri, 19 Jun 1998 09:10:01 -0700 (PDT)
Received: from ve7tcp.ampr.org (ve7tcp.ampr.org [198.161.92.132])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA09627
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 19 Jun 1998 09:04:04 -0700 (PDT)
          (envelope-from lyndon@ve7tcp.ampr.org)
Received: (from lyndon@localhost)
	by ve7tcp.ampr.org (8.9.0/8.9.0) id KAA27837;
	Fri, 19 Jun 1998 10:03:58 -0600 (MDT)
Message-Id: <199806191603.KAA27837@ve7tcp.ampr.org>
Date: Fri, 19 Jun 1998 10:03:58 -0600 (MDT)
From: Lyndon Nerenberg <lyndon@ve7tcp.ampr.org>
Reply-To: lyndon@ve7tcp.ampr.org
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/6997: vnconfig "open" error message confusing
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         6997
>Category:       bin
>Synopsis:       vnconfig "open" error message confusing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 19 09:10:01 PDT 1998
>Last-Modified:
>Originator:     Lyndon Nerenberg
>Organization:
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:

>Description:

If vnconfig can't open the device file, the error isn't too helpful.
It doesn't tall you which file the open failed on.

>How-To-Repeat:

	vnconfig -e /dev/vn0c /u1/SWAP swap

where /dev/vn0c doesn't exist.

>Fix:
	
The following patch replaces "open" with the failed pathname in the call
to warn().


*** vnconfig.c.ORIG	Fri Jun 19 09:56:40 1998
--- vnconfig.c	Fri Jun 19 09:57:26 1998
***************
*** 226,232 ****
  	rdev = rawdevice(dev);
  	f = fopen(rdev, "rw");
  	if (f == NULL) {
! 		warn("open");
  		return(1);
  	}
  	vnio.vn_file = file;
--- 226,232 ----
  	rdev = rawdevice(dev);
  	f = fopen(rdev, "rw");
  	if (f == NULL) {
! 		warn(dev);
  		return(1);
  	}
  	vnio.vn_file = file;
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message