From owner-cvs-src@FreeBSD.ORG  Tue Mar 30 10:47:05 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B326416A4CE
	for <cvs-src@freebsd.org>; Tue, 30 Mar 2004 10:47:05 -0800 (PST)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 76DFA43D5A
	for <cvs-src@freebsd.org>; Tue, 30 Mar 2004 10:47:05 -0800 (PST)
	(envelope-from nate@root.org)
Received: (qmail 81865 invoked by uid 1000); 30 Mar 2004 18:47:05 -0000
Date: Tue, 30 Mar 2004 10:47:05 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20040325.171634.59655793.imp@bsdimp.com>
Message-ID: <20040330104458.J81785@root.org>
References: <xzpvfksfztc.fsf@dwp.des.no>
	<20040325.151018.82302651.imp@bsdimp.com>
	<20040325.171634.59655793.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: wpaul@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/compat/ndis kern_ndis.c subr_ndis.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2004 18:47:05 -0000

On Thu, 25 Mar 2004, M. Warner Losh wrote:
> In message: <20040325234024.GJ26131@elvis.mu.org>
>             Alfred Perlstein <alfred@freebsd.org> writes:
> : * M. Warner Losh <imp@bsdimp.com> [040325 14:11] wrote:
> : > In message: <xzpvfksfztc.fsf@dwp.des.no>
> : >             des@des.no (Dag-Erling Sm?rgrav) writes:
> : > : Bill Paul <wpaul@FreeBSD.org> writes:
> : > :
> : > : des@dwp ~% gf BUS_GET_RESOURCE_LIST
> : > : qsrc/sys/compat/ndis/kern_ndis.c:       brl = BUS_GET_RESOURCE_LIST(device_get_parent(dev), dev);
> : > : src/sys/dev/if_ndis/if_ndis_pci.c:      rl = BUS_GET_RESOURCE_LIST(device_get_parent(dev), dev);
> : > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
> : > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
> : > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
> : > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
> : > : src/sys/kern/subr_bus.c:        rl = BUS_GET_RESOURCE_LIST(dev, child);
> : >
> : > Acutally, there are alot of downstream users of rl.
> :
> : :(
> :
> : Shouldn't we have macros:
> :
> : BUS_GET_RESOURCE_NEXT ?
> :
> : (instead of SLIST_NEXT)
>
> We already do.  bus_generic_rl_get_resource, et al.  The problem here
> is that the pci bus never intended its resources to be exposed outside
> of the bus layer.  But windows drivers need it, so there needs to be
> some tweaks need to be made.
>
> It looks like I was incorrect about the downstream uses of it.  I
> thought that pci and pccard did that, but it appears that they now use
> the common functions that matt dodd moved into subr_bus a while ago.

Fixing this to be FIFO instead of LIFO would also have helped for floppy
devices that specified a 6-port resource as three 2-port resources.  When
put in LIFO order, this gave 5-6,3-4,1-2 instead of 1-2,3-4,5-6.  The
latter would have been easier to parse.

-Nate