From owner-freebsd-current@freebsd.org Thu Apr 12 00:31:19 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE5F3F9E9EB for ; Thu, 12 Apr 2018 00:31:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 750F96C3DD for ; Thu, 12 Apr 2018 00:31:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x230.google.com with SMTP id e79so4398964ioi.7 for ; Wed, 11 Apr 2018 17:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ONsVBvGNwox634wDoGa5e3zogNcZ6nG1LYNMetO3rB8=; b=yF/QV7M9q5k2IjxpRCASlCEPCSAS7zej/FYIMDZ+JE/33DpJRhstfCSxEBiOXMM1RX iTKUAfiFZwzv3VxfHKrQjbuZx9Kaioa2RO5V+7a0PwBh79LSNigbDfbnPlz5R5nW4uul wDXFVZW2Vi8Qhro7MqlzgToxTHyTPDJbqyCa5RTDewCNtJ8TCHCKYlYOXulNNxoex2bc ajz23CkhAuZ+TIQ1S90B6IvxJ3VGI20Vqg6GhlbBxx8Djj7vTd2OyKelfVUkVB1vcRnG FbX4552IgX+CCvLU4g9SIaPLAjEQEY3LwyYT289wWgGnh7+hAxzqoTg7giqC3LVN0NNq fRCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ONsVBvGNwox634wDoGa5e3zogNcZ6nG1LYNMetO3rB8=; b=KHcBoTg61kKAgfaqQ6Rbeet4j52zoeUPgq2NjFJhGtRqlT7aGu6v+Goi6IicHryKSw Gjpt87vpO3h6dZ42W5yYXkDPcJtUNZkSXABKf8Cyhu1PgG5xYy2GT8NW3a4QOCrxzVSm tNSg/eiufhHgHhRJe1+xcqgJLingsqHDZO8gaKnxwB7B/Wt2dtlWHLlqgYiNfhoLdzaG nDRo5fOzxj8HaY2VobBveWhKTd4O0kaRoK4e6osKXk0CU70AqAUukWbBJ42HFPH6TnEp Wv66pziyxjDUkTEVPEfgbE7pObJH1kxUNVn+3L1tJQaqj6z5JIAfnjDLwDJcBD0s7voR Vp1w== X-Gm-Message-State: ALQs6tDouX0jKUu4tLKm8hc+lBRrZq2rNKT89a37txQsMYVXnUUZvYvf D7ZcDO2y5UKVtSIX9F0jrQIZMjWtDKOrfyvi4KYiIQ== X-Google-Smtp-Source: AIpwx48RW1ZQ9P5eTFCTEVkYoCZYBYeJeBa/au4oN50+OPxhS3lrWo2+oTiyp3omA8yto/Qq479qOCIJ/z1LFzRDyfk= X-Received: by 10.107.18.162 with SMTP id 34mr6818887ios.168.1523493077503; Wed, 11 Apr 2018 17:31:17 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.166.4 with HTTP; Wed, 11 Apr 2018 17:31:16 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <0e75a2ba-9a59-8301-a678-68a822025bd6@metricspace.net> <9df63df2-9d61-4106-f360-347411869b41@metricspace.net> From: Warner Losh Date: Wed, 11 Apr 2018 18:31:16 -0600 X-Google-Sender-Auth: zwtyYnVzpcWDAzdIqZWVRxY93Ck Message-ID: Subject: Re: GELI with UEFI supporting Boot Environments goes to HEAD when? To: Eric McCorkle Cc: Oliver Pinter , Tommi Pernila , "[ScaleEngine] Allan Jude" , freebsd-current , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 00:31:19 -0000 OK. I've pushed in the main part of it. The additional work I have shouldn't affect any of this stuff. I was going to look at what part(s) of your open reviewed needed to be redone tomorrow and send you feedback, but if you wanted to get a start before then, I'm happy to answer questions. All the rest of my work is going to be selecting the root partition when we're told to us a specific partition, so will be very constrained. Warner On Wed, Apr 11, 2018 at 6:02 PM, Eric McCorkle wrote: > I think the thing to do at this point is to wait for the current work on > loader.efi to land, then adapt my patches to apply against that work. > > On 04/11/2018 15:06, Warner Losh wrote: > > Still reviewing the code. I'm worried it's too i386 specific and it > > conflicts with some work I'm doing. I'll have a list of actionable > > critiques this week. > > > > Warner > > > > On Wed, Apr 11, 2018 at 1:03 PM, Oliver Pinter > > > > > wrote: > > > > Hi! > > > > Is there any update regarding the rebase or the inclusion to base > > system? > > On 3/28/18, Eric McCorkle > > wrote: > > > I'll do another rebase from head just to be sure > > > > > > On March 28, 2018 3:23:23 PM EDT, Warner Losh > > wrote: > > >>It's on my list for nexr, finally. I have an alternate patch for > > >>loader.efi > > >>from ESP, but i don't think it will affect the GELI stuff. I have > some > > >>time > > >>slotted for integration issues though. > > >> > > >>I am quite mindful of the freeze dates.... I have some uefi boot > > >>loader > > >>protocol changes that I need to get in. > > >> > > >>Warner > > >> > > >>On Feb 21, 2018 11:18 PM, "Tommi Pernila" > > wrote: > > >> > > >>> Awesome, thanks for the update and the work that you have done! > > >>> > > >>> Now we just need some more reviewers eyes on the code :) > > >>> > > >>> Br, > > >>> > > >>> Tommi > > >>> > > >>> On Thu, 22 Feb 2018 at 2.03, Eric McCorkle > > > > >>wrote: > > >>> > > >>>> FYI, I just IFC'ed everything, and the current patches are still > > >>fine. > > >>>> > > >>>> Also, the full GELI + standalone loader has been deployed on > one of > > >>my > > >>>> laptops for some time now. > > >>>> > > >>>> On 02/21/2018 18:15, Eric McCorkle wrote: > > >>>> > The GELI work could be merged at this point, though it won't > be > > >>usable > > >>>> > without an additional patch to enable loader-only operation. > The > > >>>> > patches are currently up for review: > > >>>> > > > >>>> > This is the order in which they'd need to be merged: > > >>>> > > > >>>> > > > >>>> > https://reviews.freebsd.org/D12732 > > > > >>>> > > > >>>> > This one changes the efipart device. Toomas Soome identified > > some > > >>>> > problems, which I have addressed. He has not re-reviewed it, > > >>however. > > >>>> > > > >>>> > > > >>>> > https://reviews.freebsd.org/D12692 > > > > >>>> > > > >>>> > This adds some crypto code needed for GELI. It simply adds > new > > >>code, > > >>>> > and doesn't conflict with anything. > > >>>> > > > >>>> > > > >>>> > https://reviews.freebsd.org/D12698 > > > > >>>> > > > >>>> > This adds the EFI KMS interface code, and has the EFI loader > pass > > >>keys > > >>>> > into the keybuf interface. > > >>>> > > > >>>> > > > >>>> > I can't post the main GELI driver until those get merged, as > it > > >>depends > > >>>> > on them. It can be found on the geli branch on my github > freebsd > > >>>> > repository, however. > > >>>> > > > >>>> > > > >>>> > Additionally, you need this patch, which allows loader.efi to > > >>function > > >>>> > when installed directly to the ESP: > > >>>> > > > >>>> > https://reviews.freebsd.org/D13497 > > > > >>>> > > > >>>> > On 02/20/2018 22:56, Tommi Pernila wrote: > > >>>> >> Hi Eric, > > >>>> >> > > >>>> >> could you provide a brief update how the work is going? > > >>>> >> > > >>>> >> > > >>>> >> Br, > > >>>> >> > > >>>> >> Tommi > > >>>> >> > > >>>> >> > > >>>> >> On Nov 16, 2017 04:29, "Eric McCorkle" > > > >>>> >> >> > > wrote: > > >>>> >> > > >>>> >> Right, so basically, the remaining GELI patches are > against > > >>>> loader, and > > >>>> >> most of them can go in independently of the work on > removing > > >>boot1. > > >>>> >> There's a unanimous consensus on getting rid of boot1 > which > > >>>> includes its > > >>>> >> original author, so that's going to happen. > > >>>> >> > > >>>> >> > > >>>> >> For GELI, we have the following (not necessarily in > order): > > >>>> >> > > >>>> >> a) Adding the KMS interfaces, pseudo-device, and kernel > > >>keybuf > > >>>> >> interactions > > >>>> >> b) Modifications to the efipart driver > > >>>> >> c) boot crypto > > >>>> >> d) GELI partition types (not strictly necessary) > > >>>> >> > > >>>> >> Then there's the GELI driver itself. (a) and (c) are > > good to > > >>>> land, (b) > > >>>> >> needs some more work after Toomas Soome pointed out a > > >>legitimate > > >>>> >> problem, and (d) actually needs a good bit more code (but > > >>again, > > >>>> it's > > >>>> >> more cosmetic). Additionally, the GELI driver will need > > >>further > > >>>> mods to > > >>>> >> efipart to be written (nothing too big). But we could go > > >>ahead > > >>>> with (a) > > >>>> >> and (c), as they've already been proven to work. > > >>>> >> > > >>>> >> I'd wanted to have this stuff shaped up sooner, but I'm > > >>>> preoccupied with > > >>>> >> the 7th RISC-V workshop at the end of the month. > > >>>> >> > > >>>> >> Once this stuff is all in, loader should handle any GELI > > >>volumes it > > >>>> >> finds, and it should Just Work once boot1 is gone. > > >>>> >> > > >>>> >> > > >>>> > _______________________________________________ > > >>>> > freebsd-current@freebsd.org > > mailing list > > >>>> > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > > > >>>> > To unsubscribe, send any mail to "freebsd-current-unsubscribe@ > > >>>> freebsd.org " > > >>>> > > > >>>> > > >>> > > > > > > -- > > > Sent from my Android device with K-9 Mail. Please excuse my > brevity. > > > _______________________________________________ > > > freebsd-current@freebsd.org > > mailing list > > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > > > > To unsubscribe, send any mail to > > "freebsd-current-unsubscribe@freebsd.org > > " > > > > > > > > >