From nobody Tue May 3 21:56:55 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3B1AA1AC678F; Tue, 3 May 2022 21:57:28 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from land.berklix.org (land.berklix.org [144.76.10.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "land.berklix.org", Issuer "land.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KtDMq11Qrz3Fyy; Tue, 3 May 2022 21:57:26 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p4fe6d03e.dip0.t-ipconnect.de [79.230.208.62]) (authenticated bits=128) by land.berklix.org (8.16.1/8.16.1) with ESMTPSA id 243LvL28090373 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 May 2022 21:57:25 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id 243LvFO0085389; Tue, 3 May 2022 23:57:15 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id 243Lut1R083899; Tue, 3 May 2022 23:57:05 +0200 (CEST) (envelope-from jhs@berklix.com) Message-Id: <202205032157.243Lut1R083899@fire.js.berklix.net> To: lwhsu@FreeBSD.org cc: Eugene Grosbein , freebsd-stable@FreeBSD.org, freebsd-current@FreeBSD.org, Ed Maste Subject: Re: breaking modules From: "Julian H. Stacey" Organization: http://berklix.com/jhs/ User-agent: EXMH on FreeBSD http://berklix.com/free/ X-From: http://www.berklix.org/~jhs/ In-reply-to: Your message "Tue, 03 May 2022 20:05:41 +0200." Date: Tue, 03 May 2022 23:56:55 +0200 X-Rspamd-Queue-Id: 4KtDMq11Qrz3Fyy X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jhs@berklix.com has no SPF policy when checking 144.76.10.75) smtp.mailfrom=jhs@berklix.com X-Spamd-Result: default: False [-2.10 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jhs]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[berklix.com]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-current,freebsd-stable]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:144.76.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[79.230.208.62:received] X-ThisMailContainsUnwantedMimeParts: N List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org I wrote: > > > From: bugzilla-noreply@freebsd.org > > Date: Tue, 03 May 2022 17:20:14 +0000 > > To: jhs@berklix.com > > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263758 > > > > Li-Wen Hsu changed: > > > > What |Removed |Added > > ---------------------------------------------------------------------------- > > CC| |lwhsu@FreeBSD.org > > Status|New |Open > > > > --- Comment #2 from Li-Wen Hsu --- > > Does WITHOUT_MODULES in make.conf(5) work here? > > Ouch ! Thanks ! I didn't know that existed ! I may have wasted time > re-inventing the wheel, I'll look more at both. > > PS Seems to me a whole slew of that man make.conf more properly now > belongs in src.conf ? Thanks to Li-Wen Hsu :-) I read & tested the section of /sys/modules/Makefile .for reject in ${WITHOUT_MODULES} SUBDIR:= ${SUBDIR:N${reject}} .endfor & that code works fine with both 1 & 2 modules listed. The existing code is also lots smaller than my DUD_MODULES patch, that does not use the sophistication modern bsd make ofers. So I rejected my own patch, & closed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263758 Cheers, -- Julian Stacey http://berklix.com/jhs/ http://StolenVotes.UK Kill / remove Putin: He kills innocents & causes global grain & fuel shortage.