From owner-cvs-all@FreeBSD.ORG Sat Nov 19 20:41:24 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DBB616A41F; Sat, 19 Nov 2005 20:41:24 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2BEA43D45; Sat, 19 Nov 2005 20:41:23 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id jAJKcKEn016269; Sat, 19 Nov 2005 13:38:20 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sat, 19 Nov 2005 13:38:31 -0700 (MST) Message-Id: <20051119.133831.81090859.imp@bsdimp.com> To: jdp@polstra.com From: "M. Warner Losh" In-Reply-To: References: <20051119182853.GX5197@obiwan.tataz.chchile.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Sat, 19 Nov 2005 13:38:21 -0700 (MST) Cc: jdp@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, jeremie@le-hen.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c scsi_da.c src/sys/geom geom_disk.c geom_disk.h geom_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2005 20:41:24 -0000 In message: John Polstra writes: : On 19-Nov-2005 Jeremie Le Hen wrote: : >> This fix adds a new disk_gone() function which is called by CAM when a : >> drive goes away. It orphans all of the providers associated with the : >> drive, setting an error condition of ENXIO in each one. In addition, : >> we prevent a re-taste on last close for writing if an error condition : >> has been set in the provider. : > : > This commit stirred my memory up about panicking when hot-unplugging : > an USB key while it is still mounted. I have not been able to track : > HEAD source changes attentively for some time recently but it : > appears from the above description that this awkard behaviour has been : > replaced by a smarter one (IOW, return ENXIO on all pending filesystem : > actions). : > : > Thanks in advance for explanations. : : This commit may or may not fix those panics -- I don't really know. : There is a lot that can go wrong if you remove a mounted filesystem : from the system. Meaning no offense to John, I somewhat doubt that his fix will help Jeremie's problems. The problems with mounted file systems and their disks going away is pervasive in the filesystem (and other) layers and will require a bunch of work to fix. Warner