From nobody Fri Jul 31 11:09:14 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBNcc68f2z6n2Cx for ; Fri, 31 Jul 2026 11:09:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBNcc3XY6z4638 for ; Fri, 31 Jul 2026 11:09:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785496160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A+dk8zn0BH0jtDHeBfyIPOF06saQM3i+vnY0A652Ojw=; b=Avegca3MdLtiLpCiDJSOx0O6kW0Z03bWydi+QotkYP9h/OWVGXg33RfIwGQmzp6VMoypB0 Hg4vcvNqcNR3NdmJpRg/NhxwVuCNwgtE0r6jF4s8hk5OXtg4AuOwqUNGmEp6msViWDOKqV NmGjYW0Xu5YFDz1oybQzA/EaQ/M/msvWGLSGjjf47ErjGF/W7TRWrVnCAZAVzzQK0sJLkj kqoVb0wYuLSnfhJMMU1polrXxkdvLMdi8NNILqsCzuDBEyj782EYui17j0XTKqgnEgHAr/ YgVcdmXX/k9pFQ7KmjVmBcl0tjUGkfvOn1dqr2kOWtlaguJfHa/U3fOmkZlQmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785496160; a=rsa-sha256; cv=none; b=ANqZHMaoS9jBT1Xp1orBihNHabeFLLjXvs+87njzqv9M+JxZtb1JSQZls6RO0euGdYtqtf cMGlWMsYZGHwctQUnx79SdRKbN2TDAb8vjTrcFkr5rUSlMT20yXva3jJ+sYJFAyLEEzJpA N+tSleHnfPQReIXCiuG1QqOQKHzMCdcWZoh8jRbvWA6Lwa1LJzOgNWBwB0jdsiXaozSPAw xX34lruTVQE01IKMLlZDfXbg05tOowzkKWj+15Qz5y5BSg76k6kjmhwteS31Yx7Ot8V+1N jUuCMd7O9Sxnxcux9SVuupUI2UcGiMwjTp27x6HlLn7TfgL/qPLALIOyPYWw3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785496160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A+dk8zn0BH0jtDHeBfyIPOF06saQM3i+vnY0A652Ojw=; b=rD6ULs4b1CZ4FFjd1iRrYeGMUSDeS+QtPyCit/yetRNoza6qNQruDPlNyr0Oz3Z8w91NKz /lCyR9P1A6m0GsuwWVTMpYw+zK+9aOdSBdapMbpKMA38+QVD4cLRwEy6pw3qS5Huv324HK vXiuWz0fz4q2xGgQhbXMaAmolU+7S0XSVf6M8MuIMRXf4ndCZOpzRZwJkXhW6DEuxiFX53 eWz2CMZ2tnHG6zP8Ce2Dtx05oheItJbE6tI9x1h+Dt/KEsE9vmFjDD+ibHrKWQfieogceb sHqY/DZHFUK5enHxy0Q25A4RbwcV4TLdYTbHG3ZFP/4Ix/fvDw1yy8vJNPOm8A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBNcc1w63zxP8 for ; Fri, 31 Jul 2026 11:09:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bb94 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 11:09:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Barbara Skobiej From: Kevin Bowling Subject: git: a8598143803d - main - ixgbe: check EEPROM read in 82599 D3 path List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a8598143803d8db60568844cae86b0f330e49a1e Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 11:09:14 +0000 Message-Id: <6a6c825a.3bb94.7b2d97c4@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=a8598143803d8db60568844cae86b0f330e49a1e commit a8598143803d8db60568844cae86b0f330e49a1e Author: Barbara Skobiej AuthorDate: 2026-07-28 11:08:12 +0000 Commit: Kevin Bowling CommitDate: 2026-07-31 11:07:01 +0000 ixgbe: check EEPROM read in 82599 D3 path DPDK commit message net/ixgbe/base: fix unchecked return value Check the return value from ixgbe_read_eeprom() before using the control word to configure link disable during D3. Fixes: b7ad3713b958 ("ixgbe/base: allow to disable link on D3") Cc: stable@dpdk.org Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Obtained from: DPDK (eb3684b191) MFC after: 1 week --- sys/dev/ixgbe/ixgbe_82599.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/dev/ixgbe/ixgbe_82599.c b/sys/dev/ixgbe/ixgbe_82599.c index 50902c6c356d..d23c84743b33 100644 --- a/sys/dev/ixgbe/ixgbe_82599.c +++ b/sys/dev/ixgbe/ixgbe_82599.c @@ -609,13 +609,15 @@ out: **/ void ixgbe_stop_mac_link_on_d3_82599(struct ixgbe_hw *hw) { - u32 autoc2_reg; u16 ee_ctrl_2 = 0; + u32 autoc2_reg; + s32 status; DEBUGFUNC("ixgbe_stop_mac_link_on_d3_82599"); - ixgbe_read_eeprom(hw, IXGBE_EEPROM_CTRL_2, &ee_ctrl_2); + status = ixgbe_read_eeprom(hw, IXGBE_EEPROM_CTRL_2, &ee_ctrl_2); - if (!ixgbe_mng_present(hw) && !hw->wol_enabled && + if (status == IXGBE_SUCCESS && + !ixgbe_mng_present(hw) && !hw->wol_enabled && ee_ctrl_2 & IXGBE_EEPROM_CCD_BIT) { autoc2_reg = IXGBE_READ_REG(hw, IXGBE_AUTOC2); autoc2_reg |= IXGBE_AUTOC2_LINK_DISABLE_ON_D3_MASK;