From owner-svn-src-all@freebsd.org Fri Apr 22 21:53:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 638EDB19045; Fri, 22 Apr 2016 21:53:28 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-lb0-x22f.google.com (mail-lb0-x22f.google.com [IPv6:2a00:1450:4010:c04::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D50DD1BCE; Fri, 22 Apr 2016 21:53:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-lb0-x22f.google.com with SMTP id jj5so3826648lbc.0; Fri, 22 Apr 2016 14:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=az4hXxJR6UoNjrSq0fqkvvoYlCE0IO4HHPZzdVf0F6M=; b=WHUUgcLCcbWqtoJQlW3mEgDKaqYVf1uUO7Cardl5L8aGcjtpiq+3EK0l9qzz6tt8qZ vVJtNnjgk99nH64VivAjEtVYH8AIkXYrGSUPAJIem3SAMKVIUQrx6Mjqt6bJUHv2zYfF iiddm6LUlvKQis9uQ2XJQ9llUSCfW2Z8wZSU80VwJvUnJIToPP/X2aUIAAXAN5+oagny icGV6FYb5o2Is2qSA4hfZPLcIDp2Fj9hbwHQadHALodFDtghIGIRI2kLB4vRZV01Vf1y hx7mIxbxAWRk+hfMwW5y7jMioTvm/arn81nEcBXb5cFjQlGDGiEJhY17dMqgeNicc5lg FRxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=az4hXxJR6UoNjrSq0fqkvvoYlCE0IO4HHPZzdVf0F6M=; b=cxoMPSjHRDqe7uXC2RnmhTxkhMfiVEy+VdP1um5TzfNsrGpIfTJ71wDP/MVpTRpxkU yVpMBtgTtdcK+gTOjGX1wXxE/CU7+C63YeXVqsxb1d9pv1VKmB3QBvN8ULwHVLCN9vfj IVfJv5lfnKttRQOZ4wzD84iXEgepCExMgg8rN/0Dg02FL2Jk4NDkdgAfs1KfSKkI4S7g 6ZcOnDSVvKsWLoHrz5Jai+7E2YEAnrKRxblame3mKvfEXgOzLEJmesOayzF4rvuNrnUo us3KGAE8mCiA6O2U38A1lB1vWun6t+E8X55usGPNvWUlLiGJk/yyyA51otbmQf/l9j0A EHrg== X-Gm-Message-State: AOPr4FWcMOr+ruSSLBqJW+N+NYO9ZVV+juwEkx/oAKU+BhG95Eq2C0OsB4LD/UtZaGEk4luM8bBN8RDxIbhXIg== MIME-Version: 1.0 X-Received: by 10.112.189.1 with SMTP id ge1mr9438185lbc.9.1461362004947; Fri, 22 Apr 2016 14:53:24 -0700 (PDT) Received: by 10.112.236.33 with HTTP; Fri, 22 Apr 2016 14:53:24 -0700 (PDT) In-Reply-To: <1686086.xOFMeakFfv@ralph.baldwin.cx> References: <201604222132.u3MLW1jx083176@repo.freebsd.org> <1686086.xOFMeakFfv@ralph.baldwin.cx> Date: Fri, 22 Apr 2016 14:53:24 -0700 Message-ID: Subject: Re: svn commit: r298491 - stable/10/lib/msun/tests From: Ngie Cooper To: John Baldwin Cc: Garrett Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 21:53:28 -0000 On Fri, Apr 22, 2016 at 2:49 PM, John Baldwin wrote: > On Friday, April 22, 2016 09:32:01 PM Garrett Cooper wrote: >> Author: ngie >> Date: Fri Apr 22 21:32:01 2016 >> New Revision: 298491 >> URL: https://svnweb.freebsd.org/changeset/base/298491 >> >> Log: >> MFC r297836: >> >> Fix appending -O0 to CFLAGS >> >> The previous method would completely nerf CFLAGS once bsd.progs.mk had >> recursed into the per-PROG logic and make the CFLAGS for tap testcases >> to -O0, instead of appending to CFLAGS for all of the tap testcases. > > Eh, Bryan replied to the commit that put this into HEAD saying it was a > no-op but you didn't reply. Shouldn't you address that first before MFC'ing? Yeah, I should have... I'll do that now.