From owner-p4-projects@FreeBSD.ORG  Tue Feb 28 19:52:39 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 496E916A425; Tue, 28 Feb 2006 19:52:39 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1C01216A420;
	Tue, 28 Feb 2006 19:52:39 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1358243D68;
	Tue, 28 Feb 2006 19:52:36 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost (john@localhost [127.0.0.1])
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k1SJqaKE019213;
	Tue, 28 Feb 2006 14:52:36 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Warner Losh <imp@freebsd.org>
Date: Tue, 28 Feb 2006 14:51:49 -0500
User-Agent: KMail/1.9.1
References: <200602280037.k1S0bQA5064273@repoman.freebsd.org>
In-Reply-To: <200602280037.k1S0bQA5064273@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200602281451.50834.jhb@freebsd.org>
X-Virus-Scanned: ClamAV 0.87.1/1306/Tue Feb 28 04:50:04 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=ham 
	version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 92499 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Feb 2006 19:52:40 -0000

On Monday 27 February 2006 19:37, Warner Losh wrote:
> http://perforce.freebsd.org/chv.cgi?CH=92499
> 
> Change 92499 by imp@imp_hammer on 2006/02/28 00:37:10
> 
> 	Make PIO interrupt fast...
> 
> Affected files ...
> 
> .. //depot/projects/arm/src/sys/arm/at91/at91_pio.c#5 edit
> 
> Differences ...
> 
> ==== //depot/projects/arm/src/sys/arm/at91/at91_pio.c#5 (text+ko) ====
> 
> @@ -124,7 +124,8 @@
>  	 * Activate the interrupt, but disable all interrupts in the hardware
>  	 */
>  	WR4(sc, PIO_IDR, 0xffffffff);
> -	err = bus_setup_intr(dev, sc->irq_res, INTR_TYPE_MISC | INTR_MPSAFE,
> +	err = bus_setup_intr(dev, sc->irq_res,
> +	    INTR_TYPE_MISC | INTR_MPSAFE | INTR_FAST,
>  	    at91_pio_intr, sc, &sc->intrhand);
>  	if (err) {
>  		AT91_PIO_LOCK_DESTROY(sc);
 
You don't need the MPSAFE flag then.  FAST handlers are required to be
MPSAFE and don't ever run under Giant.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org