From owner-svn-src-all@freebsd.org Fri May 25 16:36:13 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2D33EED72D; Fri, 25 May 2018 16:36:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pl0-x22b.google.com (mail-pl0-x22b.google.com [IPv6:2607:f8b0:400e:c01::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62AB068B51; Fri, 25 May 2018 16:36:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pl0-x22b.google.com with SMTP id n10-v6so3459020plp.0; Fri, 25 May 2018 09:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P4heaVNTUr60WTT7UJwmd8A4MEVIZhJLKiVQ1TnQk6c=; b=KXYzqHNMqa986T+rfoAYKzjCQ6FY5dpvZkt62I3+BO7lZUL82oM1oV/0NofJrppQZU V+lJ1ttjqCcBtnSDJMT/Jok1LaX2fcAUApkJGh9ixh/U21QC/uPYaNm2Icf826IvLtWQ ufjGaXP8suvSP7lro0aggErpZcA8CiST1JqrPpbKkH7tn7MdK8uz2xk8BnYgSPiEH9ts z82got8o+wtZJ2FmBSB9GWq1edVkSJjRxO8ekDvImG5yp7uwAMClngRwensTfcBuesc2 uLNPVtevyyzVwWLnAQe3L1ugIY0CXvZAbvCksqtpaTgWMdHhG36OhPb88Y9EProEPyIK OFew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=P4heaVNTUr60WTT7UJwmd8A4MEVIZhJLKiVQ1TnQk6c=; b=W5b2NViwcTnRs2u70Z5gE2FkNFVKdYcvpC/FfDePRLVGU2c/fa6YL5Ch8+N228Xcqh HWba8wWds/I2DjknDq2748SoP+NbSC30LWyAsHiy+L0xORMZ9H91/MtFGvnE6oXRnqku R1NNu+iAJRvgpMKnwj+JffgNtilgbL5opoWFJ0AZZGSgcmMiXEKaq7I9nigmfmD6OZC+ QEFyk5WHBRDJV+FkNc0q8wqfeZZ9OMdPhv6pYWlKfWNcfrqFCesd7ToLyNSFaKD0U01X XmNXy427+TflPDM9kp/kPwOdjOzKgMsx96KCxU0SaPhx2biD2DSqEgxxieg4pQJx1IAb wN5w== X-Gm-Message-State: ALKqPweDKBCuL0gLSae0dkblLefgHy6n3H5PX2oqKIOHqgz/eRVM/55T d6i3pb5P1ITgGRwW2xcci0Xvbg== X-Google-Smtp-Source: AB8JxZoTcRjtJa3/yaGxdm42jztKXh2iMyGJuseFOPsndIkmyswCVXXYRJdZEwcV1kQmwVel8atA9g== X-Received: by 2002:a17:902:301:: with SMTP id 1-v6mr3381944pld.328.1527266171122; Fri, 25 May 2018 09:36:11 -0700 (PDT) Received: from raichu (toroon0560w-lp140-02-70-49-169-156.dsl.bell.ca. [70.49.169.156]) by smtp.gmail.com with ESMTPSA id a4-v6sm53869405pfj.19.2018.05.25.09.36.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 May 2018 09:36:10 -0700 (PDT) Sender: Mark Johnston Date: Fri, 25 May 2018 12:36:04 -0400 From: Mark Johnston To: Matt Macy Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334118 - in head/sys: compat/linprocfs compat/linux compat/linuxkpi/common/include/linux dev/mlx5/mlx5_ib dev/wtap net net/altq netinet netinet/netdump netinet6 netpfil/pf nfs ofed/dri... Message-ID: <20180525163604.GA40082@raichu> References: <201805232102.w4NL2FaJ073854@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201805232102.w4NL2FaJ073854@repo.freebsd.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 16:36:13 -0000 On Wed, May 23, 2018 at 09:02:15PM +0000, Matt Macy wrote: > Author: mmacy > Date: Wed May 23 21:02:14 2018 > New Revision: 334118 > URL: https://svnweb.freebsd.org/changeset/base/334118 > > Log: > UDP: further performance improvements on tx > > Cumulative throughput while running 64 > netperf -H $DUT -t UDP_STREAM -- -m 1 > on a 2x8x2 SKL went from 1.1Mpps to 2.5Mpps > > Single stream throughput increases from 910kpps to 1.18Mpps > > Baseline: > https://people.freebsd.org/~mmacy/2018.05.11/udpsender2.svg > > - Protect read access to global ifnet list with epoch > https://people.freebsd.org/~mmacy/2018.05.11/udpsender3.svg > > - Protect short lived ifaddr references with epoch > https://people.freebsd.org/~mmacy/2018.05.11/udpsender4.svg > > - Convert if_afdata read lock path to epoch > https://people.freebsd.org/~mmacy/2018.05.11/udpsender5.svg After this change I can panic an INVARIANTS kernel like so. There is a freed ifaddr lingering on the lo0 ifnet's address list. # ifconfig lo0 127.0.0.2 # ifconfig lo0 -alias 127.0.0.2 # netstat -rn Routing tables Fatal trap 9: general protection fault while in kernel mode cpuid = 1; apic id = 01 instruction pointer = 0x20:0xffffffff80605219 stack pointer = 0x28:0xfffffe00004692e0 frame pointer = 0x28:0xfffffe00004693d0 code segment = base 0x0, limit 0xfffff, type 0x1b = DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags = interrupt enabled, resume, IOPL = 0 current process = 735 (netstat) trap number = 9 panic: general protection fault cpuid = 1 time = 1527266002 Uptime: 1m42s Dumping 216 out of 4079 MB:..8%..15%..23%..37%..45%..52%..67%..74%..82%..97% Dump complete Consoles: userboot