From owner-freebsd-rc@FreeBSD.ORG Wed Oct 14 18:02:25 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 078191065676 for ; Wed, 14 Oct 2009 18:02:25 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 8904F8FC18 for ; Wed, 14 Oct 2009 18:02:23 +0000 (UTC) Received: (qmail 1068 invoked by uid 399); 14 Oct 2009 18:02:23 -0000 Received: from localhost (HELO ?192.168.0.102?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 14 Oct 2009 18:02:23 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4AD6122F.3090407@FreeBSD.org> Date: Wed, 14 Oct 2009 11:02:23 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Dimitry Andric References: <4AD2460A.3000902@FreeBSD.org> <4AD59DCC.9000008@andric.com> In-Reply-To: <4AD59DCC.9000008@andric.com> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: A more thorough "Starting foo:" solution X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 18:02:25 -0000 Dimitry Andric wrote: > On 2009-10-11 22:54, Doug Barton wrote: >> After giving this a more thorough look I realized that there were >> quite a few places where $rc_quiet was being used directly in an rc.d >> script (16 scripts total). >> >> I've already committed this to HEAD in order to try and make the MFC >> deadline to potentially get it into 8.0, but I do want to give y'all a >> chance to review this change as well. >> >> If anyone objects to this change being MFC'ed to 8.0-RELEASE, or has >> other comments or suggestions please speak up ASAP. > > I see no problems with MFC'ing, this is a nice way of cleaning up. Thanks. > That said, there are still quite a number of scripts in rc.d that don't > check rc_quiet at all, and just echo whatever they like. > > Therefore, couldn't all those "check_startmsgs && echo foo" constructs, > plus the other echo's be replaced with, say, a spam() function from > /etc/rc.subr? This function can then check in one central location for > rc_startmsgs and decide whether to spam the console or not. > > One could even start implementing some verbosity level using this... :) My intention was to give users the option to get back to where things were before they were fiddled with in time for the release. I actually gave some thought along similar lines when I was working on this patch since there are some things that I restored that I personally don't care about seeing. I look forward to reviewing your patches. :) Doug