From owner-freebsd-questions@freebsd.org Thu Nov 15 16:30:51 2018 Return-Path: Delivered-To: freebsd-questions@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D577C11029ED for ; Thu, 15 Nov 2018 16:30:50 +0000 (UTC) (envelope-from husseydevin@gmail.com) Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42BDB73919 for ; Thu, 15 Nov 2018 16:30:50 +0000 (UTC) (envelope-from husseydevin@gmail.com) Received: by mail-ua1-x930.google.com with SMTP id v24so7199493uap.13 for ; Thu, 15 Nov 2018 08:30:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=TiWVnt4UQLJ3rUmO2FLJK3XNdbQzJaMeL+4O8S2Y6C4=; b=URg38gclxM7s39af/c4J8+N7rXhyAnz3S7/uyigaN4BL08rOz6PQIto4yldrDRpj42 7/MnqGD/6CsvyegKfzqDwCL5kv/lzJivJLkC1SK+dw6yi20PWPGu7Q+Wl6JJkOJXZwM7 F9RzlqT+REXlVmhedlMOL/6kkLQBuQFnLJLCZXDbigHnC/wV2iUBHwFmdWzg1pHJKG4f RSDVA0gT1IsqobDMzhO5tF5FJxXsPU7USNgLf3DOEDJZIo1OJCJDmEKVfGDQN3Ruzjgl RC+r8lwaNlu3+2HGR6cSBMyGMMy4tTB7jNbw9/SIpeH7WgiFrk5Vq6C5RAPJaUBtJMpO YNZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TiWVnt4UQLJ3rUmO2FLJK3XNdbQzJaMeL+4O8S2Y6C4=; b=ihHtrIK6wyh1yYGZ5mX8tTUIjK1hlS2JPFkkqMhyS7kgFb+lH+yX5sHLRrM8lInRFE c5BWzjOgDv0EG5EEqsOyJgaHXFcDadANWopk4iORXTvn7cVzoZH8vbnfOSXNq4j8uQ5M XhzW7a/pH3f3x/rp32UyJSzRtueZPSu55/+dITP3XNrEGjyXYL88Y7tQpcYYKpyd9euo vxu96hPtmOtcr4F+yRGlFF6grQt+sAXzC23KjD8tjXswmuAgTxFtiYxMbZuNuS15YG/b UugfMDaEjNVA2uWnRpDl46uEFvVZTxudmaO3aBdGW1OfjLrUOYlxXBI6IQr6xWjh87u+ 6vxQ== X-Gm-Message-State: AGRZ1gJLugIMCL7gb8esZfdc98dSFZQO53mUSfn6Raw/UfbqXDu+vvRX xQB4pwq1L4vyKFzwsxnUbmH9Pd0Wi5ALnR6Xqcovxg== X-Google-Smtp-Source: AJdET5dw9MxxxkajHVrZG10cNtLaWTRtZMukW0LSnOxw7l5IRFcT2SHqjlKDLWC1qiqT1xZXcCaFK1cOU1NczkWoD2I= X-Received: by 2002:ab0:2314:: with SMTP id a20mr3096743uao.130.1542299449219; Thu, 15 Nov 2018 08:30:49 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a9f:288a:0:0:0:0:0 with HTTP; Thu, 15 Nov 2018 08:30:48 -0800 (PST) From: Devin Hussey Date: Thu, 15 Nov 2018 11:30:48 -0500 Message-ID: Subject: Question about porting sh tests to dash. To: freebsd-questions@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 42BDB73919 X-Spamd-Result: default: False [-4.87 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-questions@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[0.3.9.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.95)[-0.949,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; IP_SCORE(-0.91)[ipnet: 2607:f8b0::/32(-2.65), asn: 15169(-1.81), country: US(-0.10)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 16:30:51 -0000 The dash shell has a complete lack of quality control. It has a total of zero tests, which is a problem considering it is supposed to be the reliable workhorse /bin/sh on many Linux distros. For example, I have seen a patch that was so buggy that dash couldn't even run its own ./configure script. Despite this, two versions were released without it even being noticed. Recently, it happened again: Another patch was released which broke variable expansion, five other patches pushed, a supposed "fix" for the buggy patch, that didn't even fix the most obvious bug. dash, like FreeBSD's sh, is based off of ash, and therefore would be compatible with most or all of the FreeBSD tests. I was considering porting some or all of the sh test suite to dash (obviously giving credit), as the tests are remarkably thorough. I want to know if you are all okay with it. Obviously, some tweaks would be required, such as how the tests are run. However, it would still save weeks, if not months of repetitive work and would prevent/fix many serious bugs in the codebase. Thanks, Devin Hussey