From owner-svn-ports-all@freebsd.org Sat Sep 21 18:58:19 2019 Return-Path: <owner-svn-ports-all@freebsd.org> Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 91C9512C975; Sat, 21 Sep 2019 18:58:19 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46bKbv3MPqz3NmR; Sat, 21 Sep 2019 18:58:19 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 6FCDF201DF; Sat, 21 Sep 2019 20:58:08 +0200 (CEST) Date: Sat, 21 Sep 2019 20:58:07 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Mark Linimon <linimon@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r512530 - head/audio/grip Message-ID: <20190921185807.GF2354@KGPE-D16> References: <201909211818.x8LIIXLm054927@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="svExV93C05KqedWb" Content-Disposition: inline In-Reply-To: <201909211818.x8LIIXLm054927@repo.freebsd.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46bKbv3MPqz3NmR X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>, <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/> List-Post: <mailto:svn-ports-all@freebsd.org> List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>, <mailto:svn-ports-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 21 Sep 2019 18:58:19 -0000 --svExV93C05KqedWb Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Since we force new GCC anyway on GCC platforms with USES=compiler:c++11-lang, why do a separate check for base GCC in +.if ${CHOSEN_COMPILER_TYPE} == gcc && ${COMPILER_VERSION} <= 42? On 19-09-21 18:18:33, Mark Linimon wrote: >Author: linimon >Date: Sat Sep 21 18:18:33 2019 >New Revision: 512530 >URL: https://svnweb.freebsd.org/changeset/ports/512530 > >Log: > Fix build on GCC-based systems: > > /usr/local/lib/libgraphite2.so.3: undefined reference to `__cxa_throw_bad_array_new_length@CXXABI_1.3.8' > > Approved by: portmgr (tier-2 blanket) > >Modified: > head/audio/grip/Makefile > >Modified: head/audio/grip/Makefile >============================================================================== >--- head/audio/grip/Makefile Sat Sep 21 18:14:05 2019 (r512529) >+++ head/audio/grip/Makefile Sat Sep 21 18:18:33 2019 (r512530) >@@ -18,7 +18,8 @@ LIB_DEPENDS= libcurl.so:ftp/curl \ > libid3.so:audio/id3lib \ > libpopt.so:devel/popt > >-USES= gmake libtool localbase pathfix pkgconfig >+USES= compiler:c++11-lang gmake gnome libtool localbase \ >+ pathfix pkgconfig xorg > USE_XORG= ice sm x11 xext > USE_GNOME= cairo gdkpixbuf2 gnomeprefix libgnomeui vte > >@@ -50,6 +51,8 @@ DEFAULT_CDROM_DEVICE=${WITH_CDROM_DEVICE} > DEFAULT_CDROM_DEVICE=/dev/cd0 > .endif > >+.include <bsd.port.pre.mk> >+ > pre-everything:: > .if !defined(WITH_CDROM_DEVICE) > @${ECHO_MSG} "===> The default CDROM device is ${DEFAULT_CDROM_DEVICE}" >@@ -60,5 +63,8 @@ pre-everything:: > post-patch: > @${REINPLACE_CMD} -e 's|/dev/cdrom|${DEFAULT_CDROM_DEVICE}|' \ > ${WRKSRC}/src/grip.c >+.if ${CHOSEN_COMPILER_TYPE} == gcc && ${COMPILER_VERSION} <= 42 >+ ${REINPLACE_CMD} -e '/pragma/d' ${WRKSRC}/src/cdpar.c >+.endif > >-.include <bsd.port.mk> >+.include <bsd.port.post.mk> --svExV93C05KqedWb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl2Gcr8wFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5yd3BMP/RgziX4TaB4bA6OnSbMd7eJ4ML8hxRsgWy1wbDc/sQYdXUeIEYybl6on OxDfrxoz7I2BFSu0SGgEC7K02F9j0jEWxoiUdtagEwPOdPjhbtYhR4Fc5ECxFpoS JDwGcnybYSL5GQaq+Yo33Hfr8we8dg5jye/4WemLMEa6Dbfz06QU8SdSk1k5Xuxr RiG50hxCsBXAxDn6yvzNwekT9jtc+XimVXMx7Ywy2o3OpWP8RtyfPtj0eeBjhrYm Ml2lgDFURU0xyXwLY0n6obUWuDSBebRH5H5yY5b4nggRl3JlHDDgOrMcia3hSejv 4XVIuiNgq1o8G7r+jkJTcnHyo2HDugNNaB5M0+UTgSVJZTtd/aPWU308qR25viNK WQJLN1X+Pt/GE/xXb5ny/J7EyI/Ad7A55YdRxq0d0cTI9SzNym+2YNp/y664dM14 Rg89WKnPInhvC8WXZnDkytkFQLyaIriO13jyelUh8X2DCn64TqhIlgwDF9l/1rkx qOagtJALpifey33pGQNhvkTyhZ4eu+1HoDhg8jGlwOt/LefcQLB3Cf7yKsMy1liH ahGcLoRYq3guZuqjRTOi9jUi0CusyVU6VQhqxGOSgkzbLd9ceRbMmm90Xb84fMnV 5V391U7uVE/bVDVv+9xNJivLUoZClxsUxBq6R3/JLI9+n9zj1wMQ =Svhl -----END PGP SIGNATURE----- --svExV93C05KqedWb--