From owner-cvs-all  Tue Jan  5 17:40:57 1999
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id RAA21524
          for cvs-all-outgoing; Tue, 5 Jan 1999 17:40:57 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from mail.sat.t.u-tokyo.ac.jp (dryad.sat.t.u-tokyo.ac.jp [133.11.156.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA21515;
          Tue, 5 Jan 1999 17:40:52 -0800 (PST)
          (envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp [133.11.156.43])
	by mail.sat.t.u-tokyo.ac.jp (8.8.6/3.4Wbeta6-SAT1.0) with ESMTP id KAA08132;
	Wed, 6 Jan 1999 10:40:23 +0900 (JST)
	(envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from localhost by ett.sat.t.u-tokyo.ac.jp (8.8.8/sat-V0.6)
	id KAA24499; Wed, 6 Jan 1999 10:40:23 +0900 (JST)
To: billf@jade.chc-chimes.com
Cc: kkennawa@physics.adelaide.edu.au, simokawa@FreeBSD.ORG,
        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports@FreeBSD.ORG
Subject: Re: cvs commit: ports/graphics/giftrans Makefile ports/graphics/mpeg2codec/patches         patch-aa ports/graphics/splitmpg/patches patch-aa         ports/graphics/xdl/patches patch-aa
In-Reply-To: Your message of "Tue, 5 Jan 1999 15:54:10 -0500 (EST)"
	<Pine.BSF.3.96.990105155235.29309A-100000@jade.chc-chimes.com>
References: <Pine.BSF.3.96.990105155235.29309A-100000@jade.chc-chimes.com>
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:#j7i14gu$
 jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oVuO^<vt/~051rCDM(`{rM~?{Ok
 r,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
X-Mailer: Mew version 1.93 on XEmacs 21.0 (Poitou)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <19990106104022O.simokawa@sat.t.u-tokyo.ac.jp>
Date: Wed, 06 Jan 1999 10:40:22 +0900
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
X-Dispatcher: imput version 980905(IM100)
Lines: 42
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

billf> > On Mon, 4 Jan 1999, Hidetoshi Shimokawa wrote:
billf> > 
billf> > >   Log:
billf> > >   remove -m486 option for alpha.
billf> 
billf> I'd like to second Kris's comments on CFLAGS (again.) If you(or anyone) 
billf> are taking the time to go through and make these ports kosher for Alpha,
billf> you should also be making them respect the system CFLAGS. 

O.K. I should think more about it.

He suggested to chage from:
CFLAGS =	-O2 -Dfoo -Dbar
to:
CFLAGS ?=	-O2
CFLAGS +=	-Dfoo -Dbar

But as far as I understand, CFLAGS is always set at sys.mk even if
you don't set it in make.conf. So the line "CFLAGS ?= -O2" has no effect.
(If you run gmake directly, it is not the case)
Try this Makefile:

CFLAGS ?= -use_this
CFLAGS += -addional_flags

all:
	@echo ${CFLAGS}

Then, it seems sufficient that we remove *all* optimization and machine
dependent flags and change "=" to "+=".

CFLAGS +=	-Dfoo -Dbar

Respecting system CFLAGS means ignoring application's optimization flags
completely... (we may be able to do something in ports Makefile)

If this is right, I will remove all optimization flags next time.


/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: finger -l simokawa@sat.t.u-tokyo.ac.jp

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message