From owner-svn-ports-all@freebsd.org Fri Mar 23 12:45:27 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0993F69025; Fri, 23 Mar 2018 12:45:27 +0000 (UTC) (envelope-from gabor@kovesdan.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.t-hosting.hu", Issuer "mail.t-hosting.hu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47D1372075; Fri, 23 Mar 2018 12:45:26 +0000 (UTC) (envelope-from gabor@kovesdan.org) Received: from server.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id C5D7539675D9; Fri, 23 Mar 2018 13:45:17 +0100 (CET) X-Virus-Scanned: amavisd-new at server X-Spam-Flag: NO X-Spam-Score: -2.899 X-Spam-Level: X-Spam-Status: No, score=-2.899 tagged_above=-999 required=2.5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from server.mypc.hu ([127.0.0.1]) by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id awRUZqYJKutx; Fri, 23 Mar 2018 13:45:11 +0100 (CET) Received: from webmail.mypc.hu (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 996AA3967531; Fri, 23 Mar 2018 13:45:11 +0100 (CET) Received: from ::ffff:185.81.23.140 (SquirrelMail authenticated user gabor) by webmail.mypc.hu with HTTP; Fri, 23 Mar 2018 13:45:11 +0100 Message-ID: <05db9f47f88edf0e15a5b554044d194f.squirrel@webmail.mypc.hu> In-Reply-To: <20180322115028.7qi7q65pvricwv7b@ogg.in.absolight.net> References: <201803221025.w2MAPK8R092414@repo.freebsd.org> <1a18c2f5-9151-6d2c-fd98-3d5aee9a13c4@mypc.hu> <20180322115028.7qi7q65pvricwv7b@ogg.in.absolight.net> Date: Fri, 23 Mar 2018 13:45:11 +0100 Subject: Re: svn commit: r465284 - head/x11-fonts/lohit From: "Gabor Kovesdan" To: "Mathieu Arnold" Cc: "Gabor Kovesdan" , "Mathieu Arnold" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 12:45:27 -0000 > On Thu, Mar 22, 2018 at 11:46:18AM +0100, Gabor Kovesdan wrote: >> >> >> On 3/22/2018 11:25 AM, Mathieu Arnold wrote: >> > Author: mat Date: Thu Mar 22 10:25:20 2018 New Revision: 465284 >> > URL: https://svnweb.freebsd.org/changeset/ports/465284 >> > >> > Log: Fix previous commit. >> > >> > Pointy hat: gabor Sponsored by: Absolight >> > >> > Modified: head/x11-fonts/lohit/Makefile (contents, props >> > changed) >> > >> > Modified: head/x11-fonts/lohit/Makefile >> > ============================================================================== >> > >> > >> --- head/x11-fonts/lohit/Makefile Thu Mar 22 10:14:11 2018 (r465283) >> > +++ head/x11-fonts/lohit/Makefile Thu Mar 22 10:25:20 2018 >> > (r465284) @@ -2,6 +2,7 @@ >> > >> > PORTNAME= Lohit PORTVERSION= 20140220 +PORTREVISION= 1 CATEGORIES= >> > x11-fonts MASTER_SITES= https://releases.pagure.org/lohit/ >> > DISTNAME= lohit-ttf-${PORTVERSION} @@ -22,7 +23,6 @@ PLIST_FILES= >> > ${FONTSDIR}/Lohit-Assamese.ttf \ ${FONTSDIR}/Lohit-Kannada.ttf \ >> > ${FONTSDIR}/Lohit-Malayalam.ttf \ ${FONTSDIR}/Lohit-Marathi.ttf \ >> > -# ${FONTSDIR}/Lohit-Nepali.ttf \ ${FONTSDIR}/Lohit-Oriya.ttf \ >> > ${FONTSDIR}/Lohit-Punjabi.ttf \ >> > ${FONTSDIR}/Lohit-Tamil-Classical.ttf \ >> > >> >> New version lacks the Nepali font, it wasn't commented out by mistake. >> Please revert. > > I will not revert a fix. The new version you committed also lacked Oriya > Punjabi Tamil-Classical Tamil Telugu, whatever those are. > > If you write: > > FOO= a \ > # b \ > c > > What makes understand is "FOO= a # b c". > So FOO only contains "a", not "a c". > > If you want to put back the line I removed to fix your error (which > means that obviously, neither you, nor the submitter ever tested the > patch), you can put it back, but AFTER the list. Sorry, you're right, I only tested manually and I didn't catch this... Gabor