From owner-svn-src-all@FreeBSD.ORG Mon Nov 9 18:24:35 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A980F1065693; Mon, 9 Nov 2009 18:24:35 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 62B8F8FC15; Mon, 9 Nov 2009 18:24:35 +0000 (UTC) Received: from [192.168.1.4] (adsl-19-213-63.bna.bellsouth.net [68.19.213.63]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id nA9IOXas088869 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 9 Nov 2009 13:24:33 -0500 (EST) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: Jung-uk Kim In-Reply-To: <200911091322.40212.jkim@FreeBSD.org> References: <200911062032.nA6KWRXb027876@svn.freebsd.org> <200911061647.00983.jhb@freebsd.org> <200911091322.40212.jkim@FreeBSD.org> Content-Type: text/plain Organization: FreeBSD Date: Mon, 09 Nov 2009 12:24:27 -0600 Message-Id: <1257791067.27939.25.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r199002 - in head/sys: dev/fb dev/pci isa X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 18:24:35 -0000 On Mon, 2009-11-09 at 13:22 -0500, Jung-uk Kim wrote: > On Friday 06 November 2009 04:47 pm, John Baldwin wrote: > > On Friday 06 November 2009 3:32:26 pm Jung-uk Kim wrote: > > > Author: jkim > > > Date: Fri Nov 6 20:32:26 2009 > > > New Revision: 199002 > > > URL: http://svn.freebsd.org/changeset/base/199002 > > > > > > Log: > > > Remove duplicate suspend/resume code from vga_pci.c and let > > > vga(4) > > > > register > > > > > itself to an associated PCI device if it exists. It is little > > > bit hackish but it should fix build without frame buffer driver > > > since r198964. Fix some style(9) nits in vga_isa.c while we are > > > here. > > > > Hmm, did you consider having vga_isa use an identify routine to > > attach itself as a child of vgapci0? The hack of knowing the first > > thing in the softc is a pointer is really gross and I'd rather avoid > > it. Just creating a child of vgapci0 will automatically cause > > suspend and resume to work w/o vgapci having to have any special > > knowledge about vga_isa. > > In fact, I did consider it. However, lack of my new bus foo prevented > me from doing the right thing AND fixing the build breakage at the > same. I'll try little harder today. > > BTW, syscons <-> fb <-> vga <-> vgapci <-> etc. relationship is > amazingly confusing. :-( Agreed, this is one of the things that has kept me from working on kms... robert. > Jung-uk Kim -- Robert Noland FreeBSD