From owner-cvs-src@FreeBSD.ORG  Tue May  4 09:41:55 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7CC5416A4D0
	for <cvs-src@freebsd.org>; Tue,  4 May 2004 09:41:55 -0700 (PDT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id B14E843D45
	for <cvs-src@freebsd.org>; Tue,  4 May 2004 09:41:54 -0700 (PDT)
	(envelope-from nate@root.org)
Received: (qmail 28417 invoked by uid 1000); 4 May 2004 16:41:55 -0000
Date: Tue, 4 May 2004 09:41:55 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Andre Oppermann <andre@freebsd.org>
In-Reply-To: <40975C30.5D247B83@freebsd.org>
Message-ID: <20040504093938.U28384@root.org>
References: <200405040239.i442dfL0011742@repoman.freebsd.org>
 <40970329.3070507@freebsd.org> <40975C30.5D247B83@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: Scott Long <scottl@freebsd.org>
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/net if_vlan.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 May 2004 16:41:55 -0000

On Tue, 4 May 2004, Andre Oppermann wrote:
> Scott Long wrote:
> >
> > Scott Long wrote:
> >
> > > scottl      2004/05/03 19:39:41 PDT
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/net              if_vlan.c
> > >   Log:
> > >   Add route.h to pick up the rt_ifmsg() declaration.
> > >
> > >   Revision  Changes    Path
> > >   1.60      +1 -0      src/sys/net/if_vlan.c
> >
> > Not to pick on anyone in particular, but we've had about three days in a
> > row now with tinderbox failures.  Please, everyone, step back and be
> > more careful.  Thanks,
>
> Scott, I'm sorry for that.
>
> However it worked for me just fine.  The reason I just found out is that
> I wasn't compiling if_vlan into the kernel but loaded and tested it as
> module.  Compiling it as module doesn't give any compiler warning and
> works w/o a hitch.  Dunno why?

Because -Werror doesn't get turned on for module builds nor are proper .h
files generated, leading to things like _mtx_lock_flags being undefined
when WITNESS is used for the kernel compile.  Why is this?  Because every
time someone tries to fix it, people protest.

-Nate