Date: Wed, 6 Nov 2013 06:29:01 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kris Moore <kmoore@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332589 - in head/sysutils: . grub2-bhyve Message-ID: <20131106062901.GA60770@FreeBSD.org> In-Reply-To: <201311030511.rA35BxT7011202@svn.freebsd.org> References: <201311030511.rA35BxT7011202@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 03, 2013 at 05:11:59AM +0000, Kris Moore wrote: > New Revision: 332589 > URL: http://svnweb.freebsd.org/changeset/ports/332589 > > +MASTER_SITES= http://github.com/${GH_ACCOUNT}/${PORTNAME}/archive/v${DISTVERSION}.tar.gz?dummy=/ Why is this (ugly) line needed in presence of USE_GITHUB? > +USE_GCC= 4.7 Why USE_GCC=yes (or even any) cannot be used? Even more, what's exactly wrong with Clang that port cannot be patched to support any compiler? > +USE_GMAKE= yes USE_GMAKE is deprecated, you should've added "gmake" to USES instead. > +ONLY_FOR_ARCHS= amd64 Misplaced line. It is not build-environment related; better reads just after COMMENT or LICENSE. > +MAKE_JOBS_UNSAFE= yes I will take a look how to make it -jX safe. > +CONFIGURE_ARGS= --with-platform=emu CC=gcc47 LEX=${LOCALBASE}/bin/flex --enable-grub-mount=no --enable-grub-mkfont=no Very long line. Makefiles support line wrapping via backslash (\). > +WRKSRC= ${WRKDIR}/${PORTNAME}-${DISTVERSION} If you would've used GH_* knobs correctly, you would not have to set WRKSRC. > +do-configure: > + @ cd ${WRKSRC}/ && ./configure ${CONFIGURE_ARGS} What's wrong with default do-configure target? > +do-build: > + @ cd ${WRKSRC}/ && ${GMAKE} What's wrong with default do-build target? Also, referencing GMAKE here is wrong, it should be MAKE_CMD. > +do-install: > + @${INSTALL_PROGRAM} ${WRKSRC}/grub-core/grub-emu ${STAGEDIR}${LOCALBASE}/sbin/grub-bhyve We do not mute installation comments, it pessimises debugging and confuses user that nothing was installed at all. ./danfe P.S. With all due respect Kris, don't get me wrong, but quantity of quite a few common mistakes in this commit makes me wondering if you're subscribed to svn-ports-* ML, like you probably should.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106062901.GA60770>