From owner-svn-ports-head@freebsd.org Fri Nov 23 13:22:00 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE37A1146CCA; Fri, 23 Nov 2018 13:21:59 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9660E8988C; Fri, 23 Nov 2018 13:21:59 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id AD360151B4; Fri, 23 Nov 2018 13:21:58 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Fri, 23 Nov 2018 14:21:55 +0100 From: Mathieu Arnold To: Alexey Dokuchaev Cc: Mathieu Arnold , Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r485586 - head/java/netty Message-ID: <20181123132155.quhjbh2inyq3zfug@ogg.in.absolight.net> References: <201811220930.wAM9URj7056367@repo.freebsd.org> <20181122095930.fnfd4gpowkqehznp@atuin.in.mat.cc> <20181122125524.GA37389@hades.panopticon> <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc> <20181123124845.GA50746@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rzflnkneyey5r66a" Content-Disposition: inline In-Reply-To: <20181123124845.GA50746@FreeBSD.org> User-Agent: NeoMutt/20180622 X-Rspamd-Queue-Id: 9660E8988C X-Spamd-Result: default: False [2.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_SPAM_LONG(0.44)[0.441,0]; NEURAL_SPAM_MEDIUM(0.88)[0.878,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_SPAM_SHORT(0.68)[0.680,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 13:22:00 -0000 --rzflnkneyey5r66a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 23, 2018 at 12:48:45PM +0000, Alexey Dokuchaev wrote: > On Thu, Nov 22, 2018 at 05:19:28PM +0100, Mathieu Arnold wrote: > > On Thu, Nov 22, 2018 at 03:55:24PM +0300, Dmitry Marakasov wrote: > > > * Mathieu Arnold (mat@FreeBSD.org) wrote: > > > > > -PLIST_FILES=3D %%JAVAJARDIR%%/netty-${PORTVERSION}.jar \ > > > > > - %%JAVAJARDIR%%/netty.jar > > > > > +PLIST_FILES=3D ${JAVAJARDIR:S,^${PREFIX}/,,}/netty-${PORTVERSION= }.jar \ > > > > > + ${JAVAJARDIR:S,^${PREFIX}/,,}/netty.jar > > > >=20 > > > > This seems overly complicated. What is wrong with having just > > > > ${JAAAVJARDIR}? > > >=20 > > > It contains absolute path. I've assumed we don't use these in the pli= st. > >=20 > > Paths in the PLIST are either relative to PREFIX or absolute. If a path > > is absolute and starts with PREFIX, it is just fine. >=20 > Absolute paths, however, look ugly in PLIST, and generally do not sound > like a good idea (e.g., how well do they align with relocatable packages)? Have a look at the content of a package, all the files in them have full paths. Relocation works by doing a s|^/usr/local|/bar|. =20 As for the ugly, well, I find ${JAVAJARDIR:S,^${PREFIX}/,,} much worse than having full path that you will never see because it is hidden in variables. --=20 Mathieu Arnold --rzflnkneyey5r66a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlv3/vJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkhPog//VCco1RsslrpwDchEQQ8SqXkxKKnCh+JEI/Qw/hy4Z6xIHOSw6RO4cj72 ASIGG8Zpn0Ihx0rPfmsXFgdbK1jFNIe6kssOk6Cc28Ci3DUzQShmhwUmOJ/kPyrY HVbu/idgVMn8xAVKshzDtVw/jQIPkTEhaXCvFIoGD4cZFEIVmV6T/UwM39/Z33L6 a36vIoH4JTpLleGjnzTXjPKuuZczxhAaJRCP69SuF8EIwTQ/tNtddbe7QVYJd/0E Hj4BTmbCbeGDSp2KGciTJSpb5/DXf5jDM1S5nLy7SNEB46T6zESin6JyZE66NUXB FFNPzqNv3rmTiwXLatpKdXLM6tmIZ65t0+LosX3u/TvW6SfAFPYJRYsGf8anEfQH OCxt1wCdPzXPceUXtnm4rube9HxxIjOtAuoJfgop4V0AufIYzr1oGbHisOvrw/Q9 n0rIHHpTYuGCfs4URa/4PMGiisiAdpu2KKrQ+t4A5dbw5RgKjkoPwP2HiUlH6I+P amK8y4L1XNWNtBts2K4dm0KA0t1B4gNVCxhHoNSNluEvRwfFYakRDZqef9k5R9sO muReygBs0D3ooDAjsF9faRVwEsZ9yPO+76geOkWtsYmz+lVdjkLKAHx4fx/fUpbO yGRJgkGQg+zw7RWgozcO2Nl8OyhIMu90ZYmtdq+KZ3+mTeaM2HE= =w76m -----END PGP SIGNATURE----- --rzflnkneyey5r66a--