Date: Sat, 19 Oct 2019 21:28:32 +0000 From: =?UTF-8?Q?Vin=C3=ADcius_Zavam?= <egypcio@freebsd.org> To: koobs@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513663 - head/www/py-lektor Message-ID: <CA%2BKr6DOOqkRubFgYQeWVpLPhGBH2OgqnZyZku_i0_rzSYNfvhQ@mail.gmail.com> In-Reply-To: <f3b2b8bb-da8a-4a75-2178-3fbe7c910c8e@FreeBSD.org> References: <201910031250.x93Coclr080961@repo.freebsd.org> <f3b2b8bb-da8a-4a75-2178-3fbe7c910c8e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
adding to my TODO here. thanks! Am Fr., 4. Okt. 2019 um 02:30 Uhr schrieb Kubilay Kocak <koobs@freebsd.org>= : > On 3/10/2019 10:50 pm, Vin=C3=ADcius Zavam wrote: > > Author: egypcio > > Date: Thu Oct 3 12:50:38 2019 > > New Revision: 513663 > > URL: https://svnweb.freebsd.org/changeset/ports/513663 > > > > Log: > > www/py-lektor: add devel/py-pip to RUN_DEPENDS > > > > - Makefile > > based on upstream's setup.py, adding 'pip' to RUN_DEPENDS; > > without 'pip' the lektor application wouldn't work as expected. > > > > https://github.com/lektor/lektor/blob/3.1.3/setup.py > > > > Modified: > > head/www/py-lektor/Makefile > > > > Modified: head/www/py-lektor/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/www/py-lektor/Makefile Thu Oct 3 11:18:02 2019 > (r513662) > > +++ head/www/py-lektor/Makefile Thu Oct 3 12:50:38 2019 > (r513663) > > @@ -2,6 +2,7 @@ > > > > PORTNAME=3D Lektor > > PORTVERSION=3D 3.1.3 > > +PORTREVISION=3D 1 > > CATEGORIES=3D www devel python > > MASTER_SITES=3D CHEESESHOP > > PKGNAMEPREFIX=3D ${PYTHON_PKGNAMEPREFIX} > > @@ -20,7 +21,8 @@ RUN_DEPENDS=3D > ${PYTHON_PKGNAMEPREFIX}Jinja2>=3D2.4:devel/ > > ${PYTHON_PKGNAMEPREFIX}Babel>=3D0:devel/py-babel@${PY_FLA= VOR} > \ > > ${PYTHON_PKGNAMEPREFIX}setuptools>=3D0:devel/py-setuptool= s@${PY_FLAVOR} > \ > > ${PYTHON_PKGNAMEPREFIX}requests>=3D0:www/py-requests@${PY= _FLAVOR} > \ > > - ${PYTHON_PKGNAMEPREFIX}inifile>=3D0.4:devel/py-inifile@ > ${PY_FLAVOR} > > + ${PYTHON_PKGNAMEPREFIX}inifile>=3D0.4:devel/py-inifile@${= PY_FLAVOR} > \ > > + ${PYTHON_PKGNAMEPREFIX}pip>=3D0:devel/py-pip@${PY_FLAVOR} > > > > USES=3D python > > USE_PYTHON=3D autoplist distutils > > > > The only place pip is used is in WRKSRC/lektor/packages.py > > def download_and_install_package > def install_local_package > > And pip should not be used to install dependencies > > pip should be removed from (patched out of) from install_requires and > *_requires (extras_require, etc) used instead to describe > additional/extra/non-compulsory dependencies) > > This should be sent/fixed upstream. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BKr6DOOqkRubFgYQeWVpLPhGBH2OgqnZyZku_i0_rzSYNfvhQ>