From owner-freebsd-ports@FreeBSD.ORG Wed Nov 26 14:26:54 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA35B16A4CE; Wed, 26 Nov 2003 14:26:54 -0800 (PST) Received: from hueymiccailhuitl.mtu.ru (hueytecuilhuitl.mtu.ru [195.34.32.123]) by mx1.FreeBSD.org (Postfix) with ESMTP id 267E343FE1; Wed, 26 Nov 2003 14:26:51 -0800 (PST) (envelope-from sem@ciam.ru) Received: from ciam.ru (ppp152-50.dialup.mtu-net.ru [62.118.152.50]) by hueymiccailhuitl.mtu.ru (Postfix) with ESMTP id 168391AAC70; Thu, 27 Nov 2003 01:26:49 +0300 (MSK) (envelope-from sem@ciam.ru) Message-ID: <3FC528AD.2050108@ciam.ru> Date: Thu, 27 Nov 2003 01:26:53 +0300 From: Sergey Matveychuk User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.5) Gecko/20031120 X-Accept-Language: en-us, en MIME-Version: 1.0 To: ports@FreeBSD.org, marcus@freebsd.org Content-Type: multipart/mixed; boundary="------------080305060701010604070500" Subject: PORTVERSION and portlint X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Nov 2003 22:26:54 -0000 This is a multi-part message in MIME format. --------------080305060701010604070500 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit What's wrong with '+' sign in PORTVERSION? www/apache13+modssl, russian/apache* and dns/bind9-dlz ports use it for separating port version and module version. I think it's a good practice. But portlint marks it as FATAL. May be make a sense this simple patch to apply? --- Sem. --------------080305060701010604070500 Content-Type: text/plain; name="portlint.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="portlint.patch" --- portlint.orig Thu Nov 27 01:22:30 2003 +++ portlint Thu Nov 27 01:23:04 2003 @@ -1535,7 +1535,7 @@ &perror("FATAL: $file: PORTVERSION must be specified"); } if ($portversion =~ /^pl[0-9]*$/ - || $portversion =~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9]*)*$/) { + || $portversion =~ /^[0-9]*[A-Za-z]?[0-9]*(\.[0-9]*[A-Za-z]?[0-9+]*)*$/) { print "OK: PORTVERSION \"$portversion\" looks fine.\n" if ($verbose); } elsif ($portversion =~ /^[^\-]*\$[{\(].+[\)}][^\-]*$/) { &perror("WARN: $file: using variable, \"$portversion\", as version ". --------------080305060701010604070500--