From owner-svn-ports-head@freebsd.org Fri May 17 10:58:21 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 117F51591382; Fri, 17 May 2019 10:58:21 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 855D46E6DA; Fri, 17 May 2019 10:58:20 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x533.google.com with SMTP id c13so3154720pgt.1; Fri, 17 May 2019 03:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yQk/MUvaRTU/pSHzoLGTfJ7bcRCmiy/+dU7vKx00u/Y=; b=MK/DD019+CTwUTfakyCxfNPo6NITtdz+qEbttCJ9j+8xaFtnhDp7KVXzDIw92HhEUJ 6l5yskDOtzShXE0GASFSZZjLq8kbq/1lKM+OcukA50lkyeR6azZyg6QoB+r2bq7/PPhr BA3HSuN6LkEtoPu8xiu5YpDBc3PhtjHR3boiPcmvM3MkES4pDiaYOTQBykZVqqk+jdw4 upKRCHHrgCc9535LyBUvSTgaRKRWBWYRQFVoE/b02UYa0iLKUQeDabc6AKGTa/q1AzZi K8llggWQqHTpS7A8sOZkzcI/2hqFZiexx2P9e4uJMu/7x/ALEasGhjpLgF3hfPuBlA5O lzbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yQk/MUvaRTU/pSHzoLGTfJ7bcRCmiy/+dU7vKx00u/Y=; b=UceiEMk0CSYOJ6mNGsD3BRNitS7jAfOlO5x0yKRcH3xgpXMF4gIA5FyTlvd8mYGGz6 1Ahzqn0LEqqF7aIcLcv9cBs36Ia24AyN5OEuC18ypIPIb764Y2goNgF1qwd98aqd9oJB xW4mAsOnhyPGTZi6NJlrCg+t/B3ygNfW5JxC5J0dFdonI/7Qj2KSmk3BCHsn/7uQswtO AdIyIATfYiPxLeJDKrtGfmqoicAK7x2blTskiZSrGufCZUffTtdB5WBqRHtLSsocm41V haPoBzm4NAlStH/8EWYP8cjJP4+Rp3HT2p+j/Y3aUsSabsXEKWLTYxAB1wniniGXWC18 TtqQ== X-Gm-Message-State: APjAAAWiPZkpCGLXLJ7Cgx/rud21bSoi4ustZjG68qczrlyK+XvgBE4N wvnwv0wEPiE20vVLumSQd6ZwDjgg X-Google-Smtp-Source: APXvYqy8XVtfGlhcDreGFHaNP7oj+sS2tRErOGyorAZIeBIqFev1s9sCwz8M367s9vbFCsLsyqUNWg== X-Received: by 2002:aa7:842f:: with SMTP id q15mr60446932pfn.161.1558090698969; Fri, 17 May 2019 03:58:18 -0700 (PDT) Received: from [192.168.1.105] (121-200-20-216.79c814.syd.nbn.aussiebb.net. [121.200.20.216]) by smtp.gmail.com with ESMTPSA id r18sm22357322pfg.141.2019.05.17.03.58.16 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 03:58:18 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r501839 - head/www/py-websocket-client To: Antoine Brodin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201905170822.x4H8MRgW081754@repo.freebsd.org> From: Kubilay Kocak Message-ID: <186d3850-2cf7-bac4-f568-2c370c3554bc@FreeBSD.org> Date: Fri, 17 May 2019 20:58:15 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Thunderbird/67.0 MIME-Version: 1.0 In-Reply-To: <201905170822.x4H8MRgW081754@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 855D46E6DA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 10:58:21 -0000 On 17/05/2019 6:22 pm, Antoine Brodin wrote: > Author: antoine > Date: Fri May 17 08:22:27 2019 > New Revision: 501839 > URL: https://svnweb.freebsd.org/changeset/ports/501839 > > Log: > Unbreak at runtime > > Pointy hat: koobs > > Modified: > head/www/py-websocket-client/Makefile > > Modified: head/www/py-websocket-client/Makefile > ============================================================================== > --- head/www/py-websocket-client/Makefile Fri May 17 08:00:59 2019 (r501838) > +++ head/www/py-websocket-client/Makefile Fri May 17 08:22:27 2019 (r501839) > @@ -3,6 +3,7 @@ > > PORTNAME= websocket-client > PORTVERSION= 0.56.0 > +PORTREVISION= 1 > CATEGORIES= www python > MASTER_SITES= CHEESESHOP > PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > @@ -24,7 +25,13 @@ USE_PYTHON= distutils concurrent autoplist > > NO_ARCH= yes > > +.include > + > +.if ${PYTHON_REL} < 3500 > +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}backports.ssl_match_hostname>0:security/py-backports.ssl_match_hostname@${PY_FLAVOR} > +.endif > + > do-test: > @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test > > -.include > +.include > Thanks Antoine, but what was the actual error observed? I QA'd this pretty thoroughly (including a full test suite run/pass) so it would be handy to know the exact failure mode Python > 2.7.9 has match_hostname and websocket-client checks for the stdlib before falling back to backports: if hasattr(ssl, "match_hostname"): from ssl import match_hostname else: from backports.ssl_match_hostname import match_hostname