Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Sep 2024 23:55:21 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Warner Losh <imp@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 5d889e60c15c - main - amd64: move the right parenthesis to the right place
Message-ID:  <ZttsOYOKyRtSPY0c@kib.kiev.ua>
In-Reply-To: <202409061835.486IZJxv011127@gitrepo.freebsd.org>
References:  <202409061835.486IZJxv011127@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 06, 2024 at 06:35:19PM +0000, Warner Losh wrote:
> The branch main has been updated by imp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=5d889e60c15ce7856cb9a9bc258dab8aaeb94efe
> 
> commit 5d889e60c15ce7856cb9a9bc258dab8aaeb94efe
> Author:     Wuyang Chung <wy-chung@outlook.com>
> AuthorDate: 2024-08-02 06:44:38 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-09-06 18:34:31 +0000
> 
>     amd64: move the right parenthesis to the right place
>     
>     Reviewed by: imp, emaste
>     Pull Request: https://github.com/freebsd/freebsd-src/pull/1356
> ---
>  sys/amd64/amd64/machdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/amd64/amd64/machdep.c b/sys/amd64/amd64/machdep.c
> index 025c3c365de5..f4b3b9702e00 100644
> --- a/sys/amd64/amd64/machdep.c
> +++ b/sys/amd64/amd64/machdep.c
> @@ -1382,7 +1382,7 @@ hammer_time(u_int64_t modulep, u_int64_t physfree)
>  	 */
>  	for (x = 0; x < NGDT; x++) {
>  		if (x != GPROC0_SEL && x != (GPROC0_SEL + 1) &&
> -		    x != GUSERLDT_SEL && x != (GUSERLDT_SEL) + 1)
> +		    x != GUSERLDT_SEL && x != (GUSERLDT_SEL + 1))
>  			ssdtosd(&gdt_segs[x], &gdt[x]);
>  	}
>  	gdt_segs[GPROC0_SEL].ssd_base = (uintptr_t)&pc->pc_common_tss;
The moved parenthesis are not needed at all, and should be removed
according to style.  Same for the () in the previous line.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZttsOYOKyRtSPY0c>