Date: Tue, 15 Aug 2006 22:48:17 +0200 From: Divacky Roman <xdivac02@stud.fit.vutbr.cz> To: Kip Macy <kmacy@fsmware.com> Cc: Alexander Leidinger <Alexander@Leidinger.net>, Suleiman Souhlal <ssouhlal@freebsd.org>, current@freebsd.org Subject: Re: HEADS-UP: starting to commit linuxolator (SoC 2006) changes... Message-ID: <20060815204817.GA75819@stud.fit.vutbr.cz> In-Reply-To: <20060815130418.I18116@demos.bsdclusters.com> References: <20060815141151.15ae4349@Magellan.Leidinger.net> <44E1BD03.2030402@FreeBSD.org> <20060815144625.362bf376@Magellan.Leidinger.net> <44E1C3E4.7080508@FreeBSD.org> <20060815153451.604d16f1@Magellan.Leidinger.net> <20060815130418.I18116@demos.bsdclusters.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 15, 2006 at 01:04:52PM -0700, Kip Macy wrote: > What does testing buy us when you've already admitted that futexes et > al. are broken? the futexes are not 100% working which is different from broken. it passes my pthread tests and its able to run quite complicated programs (firefox, opera) the problem is (for example) with realplay which hangs waiting on a futex when I attempt to play a file. I noticed that this behaviour changes based upon what pid I copy out to the parent thread (when I copy linux-tid ff/opera works and realplay not, when I copy linux-pid ff is broken, realplay works). if anyone has an idea what can cause this feel free to tell me. the point is - other people might see what the bug is. I dont see it. what commiting this code into src means? 1) more eyeballs to review 2) coverity run - I strongly suggest extending coverity to run on some p4 branches 3) some panics etc. might be revealed 4) the commit is almost 100% self-contained and doesnt break anything while I agree that Alexander could wait 2-3 days in general case I also know his reasons why he commited it so fast - his vacation ends and he wanted to devote today to integrating this stuff into the cvs. On the other hand I've seen too many patches which got never integrated that I am glad this one is different. my 2 cents Roman Divacky (the author of the patch in question)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060815204817.GA75819>