From owner-freebsd-threads@freebsd.org  Fri Sep 25 16:50:50 2015
Return-Path: <owner-freebsd-threads@freebsd.org>
Delivered-To: freebsd-threads@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21FADA089FD
 for <freebsd-threads@mailman.ysv.freebsd.org>;
 Fri, 25 Sep 2015 16:50:50 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0040C11FF
 for <freebsd-threads@freebsd.org>; Fri, 25 Sep 2015 16:50:50 +0000 (UTC)
 (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0DD45B923;
 Fri, 25 Sep 2015 12:50:49 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Jason Schulz <schulz.j@gmail.com>, freebsd-threads@freebsd.org
Subject: Re: pthread_getaffinity_np issue
Date: Fri, 25 Sep 2015 09:37:55 -0700
Message-ID: <5496698.OIvuy2PFgu@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; )
In-Reply-To: <20150924192623.GL67105@kib.kiev.ua>
References: <20150924181127.GC3104@gmail.com>
 <20150924191121.GG3104@gmail.com> <20150924192623.GL67105@kib.kiev.ua>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 25 Sep 2015 12:50:49 -0400 (EDT)
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads/>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Sep 2015 16:50:50 -0000

On Thursday, September 24, 2015 10:26:23 PM Konstantin Belousov wrote:
> So your issue only appears when you specify _XOPEN_SOURCE.  This is reasonable,
> because __bitcount stuff in sys/types.h was put under _BSD_VISIBLE protection.
> I am not sure why and I Cc:ed the author of the change.
> 
> IMO all symbols from __bitcount* are in the private namespace and could
> be made unconditionally accessible, to avoid surprises.  I put the patch
> at the end of the message which does this.

It was not on purpose, more to put it in the section with other "doodads".
If it is safe to move out from under BSD_VISIBLE then your patch is fine
with me.  The only person I can think to ask would be bde@, but my guess
is your change is correct.

-- 
John Baldwin