Date: Sat, 15 Mar 2014 09:54:32 -0600 (MDT) From: John Hein <john.hein@microsemi.com> Cc: gnome@freebsd.org, kwm@freebsd.org Message-ID: <201403151554.s2FFsWZ2098674@gromit.timing.com>
next in thread | raw e-mail | index | archive | help
>Submitter-Id: current-users
>Originator: John Hein
>Organization:
>Confidential: no
>Synopsis: [patch] fix staged pango
>Severity: non-critical
>Priority: low
>Category: ports
>Class: change-request
>Release:
>Environment:
>Description:
If pango did not exist before on a system, then <prefix>/etc/pango
would not be there. When the pkg or port is installed, the @exec that
invokes pango-querymodules in the plist will silently fail because of
the missing directory.
>How-To-Repeat:
mv /usr/local/etc/pango /usr/local/etc/pango.mv
portmaster x11-toolkits/pango
Observe that packages that are dependent on pango for loading fonts
no longer load fonts, and you might see an error like so:
(pan:27235): Pango-CRITICAL **: No modules found:
No builtin or dynamically loaded modules were found.
PangoFc will not work correctly.
This probably means there was an error in the creation of:
'/usr/local/etc/pango/pango.modules'
You should create this file by running:
pango-querymodules > '/usr/local/etc/pango/pango.modules'
>Fix:
Remove the creation of the etc/pango dir from post-install. Now
that this port supports staging, that doesn't help with the
installed port. Instead create the directory in the plist.
While here, use PREFIX for the path to pango-querymodules in plist.
That seems more correct than LOCALBASE.
Index: Makefile
===================================================================
--- Makefile (revision 348052)
+++ Makefile (working copy)
@@ -56,7 +56,6 @@
.endif
post-install:
- @${MKDIR} ${STAGEDIR}${PREFIX}/etc/pango/
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libpango*-1.0.so.0
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/pango/*/modules/pango-*.so
Index: pkg-plist
===================================================================
--- pkg-plist (revision 348052)
+++ pkg-plist (working copy)
@@ -141,4 +141,5 @@
@dirrm include/pango-1.0/pango
@dirrm include/pango-1.0
@dirrm etc/pango
-@exec %%LOCALBASE%%/bin/pango-querymodules > %D/etc/pango/pango.modules
+@exec mkdir %D/etc/pango
+@exec %%PREFIX%%/bin/pango-querymodules > %D/etc/pango/pango.modules
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403151554.s2FFsWZ2098674>