Date: Wed, 15 Jul 2015 16:09:36 +0000 From: "imp (Warner Losh)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2378: Introduce ITS support for ARM64 Message-ID: <120ef6b71eda08b3dcaf8d29159fc845@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-xmqmcfafyun443233vly-req@FreeBSD.org> References: <differential-rev-PHID-DREV-xmqmcfafyun443233vly-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
imp added inline comments. INLINE COMMENTS sys/arm64/arm64/gic_v3_fdt.c:299 There are very few drivers in the tree that have multiple attachments in the same file. It complicates subsetting and modules a bit is the general reason why that's the case. In this case it might be OK, it might not (I haven't looked at the larger context). What makes it more convenient to do it this way? Since I didn't see it in a quick glance, chances are good that a comment or two about why they are co-located would be in order. REVISION DETAIL https://reviews.freebsd.org/D2378 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: zbb, imp, ian, emaste, manpages, andrew Cc: eadler, gnn, kib, emaste, andrew, freebsd-arm-list, imp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?120ef6b71eda08b3dcaf8d29159fc845>