From owner-svn-src-all@freebsd.org Mon Jun 10 15:03:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4E6A15C196A for ; Mon, 10 Jun 2019 15:03:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 21F8E7716B for ; Mon, 10 Jun 2019 15:03:04 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1560178978; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=TvyjMImqQr5aHkcIYsAazDeqKS+bkGZQaISPmpZEIXZdc0UfWxVu8Q6v7jqeKE2qvOEJZ2B+WiP9h 1ZB7gQu8lBA46b+RB9v3P14xhagX2qzV8XR/BO/cEV62W6ZenfhV821whAI48ooAkUvcqmHfUN7NIB qCzByfH3I60I2TjJ3QeEwduZjsj5tY7cCgcFxAcMTFiZhmLNfXJe2ZfLkGXe21ZCLDHPIL2SYx9GnM zJlo6ROT9gfzZN9P4iCp1uC8kwPjU9Q1mcJGPi+x9XqmwLHjys7imXKc6CMeQcSzF0lf7+9d4RkR2H 2NPAYKLKbWDx7YkHbaoLKgTBH05rxsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=R9i3lO7JrqtAhhGre0IpWylWEL5819Ni66n+Kw4olkE=; b=UTznR7oSspH4NqoEI0KYM2TTAAE2y7p5PR8DbSPdfo99NEhIu7wOdMwmo0cju7h6/ahSMLsSw/CO7 FfQBWUK67g0KL/6cm+64g8GuMbUcn3Vczbyoa0RPTrM6DAgJuEWVVaCiIMnypDk1nQoHvhTw+8oeGl NbnHNj2TB4VoUyK+pOLn3N9Hz64jeCKLd4As9uDgZvoHXLzrc9cnOOH0taIBvz52ygxnJ4557d2y8N 5K9iEIL3dya5kbytU2sad6Dg/XSOLAoHEiYnUekpnbvImO5c8LzfliKqjlSw7BMdpMzvVE0Ktm34F3 rHAqzheRhPS4uT220G4cMEZdKXWNtEw== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=R9i3lO7JrqtAhhGre0IpWylWEL5819Ni66n+Kw4olkE=; b=pHultbCdbCy2jV0InfACrhHOUlUC58oNqro/AqC8gK4kAcoavvOeaJEw31WObCtBl1+2OP1WYfmNR bEb3jas5G0l41sKySdGL0Z1vrZGqxcktaPgLQHSsvDM9ge1eHU+55zHzJbbEQrq5xs+8ULblNOgqx+ 82ttGRBjodTtyXBiA5cJO3hL9dBt3U5xSXFCVeuT6EZDJ9WCYb+vFOTyBIE7zQdKAkP4WkOlfTN2zn QG8FJwoVEpz6BeK1NWupsKdipApK6NFP5lvlrQZaMzv1WQ4gmyUYH0aAGoN/hDiRHoFVQ7vaL2YO6h fTpU0mhlUpUlArqezGoK1ZKveW8r3Sw== X-MHO-RoutePath: aGlwcGll X-MHO-User: d3b7eddc-8b90-11e9-b39a-9d2c53d3dedb X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id d3b7eddc-8b90-11e9-b39a-9d2c53d3dedb; Mon, 10 Jun 2019 15:02:56 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x5AF2tSX084496; Mon, 10 Jun 2019 09:02:55 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r348847 - head/sys/sys From: Ian Lepore To: Warner Losh , "Conrad E. Meyer" Cc: Tijl Coosemans , src-committers , svn-src-all , svn-src-head Date: Mon, 10 Jun 2019 09:02:55 -0600 In-Reply-To: References: <201906100528.x5A5S4gm072561@repo.freebsd.org> <20190610110909.3e6fbc13@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 21F8E7716B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 15:03:06 -0000 On Mon, 2019-06-10 at 07:49 -0600, Warner Losh wrote: > On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: > > > On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans > > wrote: > > > On Mon, 10 Jun 2019 05:28:04 +0000 (UTC) Dmitry Chagin > > > wrote: > > > > ... > > > > URL: https://svnweb.freebsd.org/changeset/base/348847 > > > > Log: > > > > Use C11 anonymous unions. > > > > > > > > Modified: head/sys/sys/ucred.h > > > > > > ... > > > > > > Isn't this a userland header that should work with non-C11 > > > compilers? > > > > Hi Tijl, > > > > Why would one expect userland headers to work with non-C11 (gnu89) > > compilers? > > > > Because those compilers can choose non c11 variants of the language? > > Warner > Do we promise that userland will compile with -std=c89? I hope not. Anonymous unions may be a c11 feature, but they're also available with -std=gnu99, which I think is how we compile userland. I think -std=gnu99 is how we should also compile the kernel, and I think Bruce has been trying to say that for several years (but I'm not sure, because the emails that seem to say so are always so full of semi-related extraneous material that it's hard to be sure what they're saying). -- Ian