From owner-cvs-ports@FreeBSD.ORG Mon Jul 16 18:36:27 2007 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 52CA816A404 for ; Mon, 16 Jul 2007 18:36:27 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id EAAC113C4C3 for ; Mon, 16 Jul 2007 18:36:26 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 8486 invoked by uid 399); 16 Jul 2007 18:36:26 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 16 Jul 2007 18:36:26 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <469BBAA8.80802@FreeBSD.org> Date: Mon, 16 Jul 2007 11:36:24 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.4 (X11/20070617) MIME-Version: 1.0 To: Rong-En Fan References: <200707161053.l6GArmei061828@repoman.freebsd.org> In-Reply-To: <200707161053.l6GArmei061828@repoman.freebsd.org> X-Enigmail-Version: 0.95.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases/pgcluster Makefile pkg-plist ports/databases/pgcluster/files patch-configure.in pgcluster.in pgcluster.sh.tmpl pglb.in pglb.sh.tmpl pgreplicate.in pgreplicate.sh.tmpl X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2007 18:36:27 -0000 Rong-En Fan wrote: > rafan 2007-07-16 10:53:48 UTC > > FreeBSD ports repository > > Modified files: > databases/pgcluster Makefile pkg-plist > Added files: > databases/pgcluster/files patch-configure.in pgcluster.in > pglb.in pgreplicate.in > Removed files: > databases/pgcluster/files pgcluster.sh.tmpl pglb.sh.tmpl > pgreplicate.sh.tmpl > Log: > - Patch configure.in so it accepts --infodir option [1] > - While I'm here, use USE_RC_SUBR facility for rc scripts This is always welcome of course, but there are some small oddities with the rc.d scripts. You might want to take a look at http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html, especially the bit about how to do the default variable assignments. It would be better to follow the order that's in the example script on that page, for a variety of reasons that I can elaborate if you wish. Doug > Revision Changes Path > 1.16 +6 -12 ports/databases/pgcluster/Makefile > 1.1 +26 -0 ports/databases/pgcluster/files/patch-configure.in (new) > 1.1 +56 -0 ports/databases/pgcluster/files/pgcluster.in (new) > 1.5 +0 -56 ports/databases/pgcluster/files/pgcluster.sh.tmpl (dead) > 1.1 +34 -0 ports/databases/pgcluster/files/pglb.in (new) > 1.5 +0 -34 ports/databases/pgcluster/files/pglb.sh.tmpl (dead) > 1.1 +36 -0 ports/databases/pgcluster/files/pgreplicate.in (new) > 1.5 +0 -36 ports/databases/pgcluster/files/pgreplicate.sh.tmpl (dead) > 1.3 +0 -3 ports/databases/pgcluster/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/Makefile.diff?&r1=1.15&r2=1.16&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/patch-configure.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgcluster.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgcluster.sh.tmpl > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pglb.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pglb.sh.tmpl > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgreplicate.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/files/pgreplicate.sh.tmpl > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/pgcluster/pkg-plist.diff?&r1=1.2&r2=1.3&f=h > -- This .signature sanitized for your protection