From owner-svn-src-all@FreeBSD.ORG Sat May 17 17:08:50 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 700BDAF1 for ; Sat, 17 May 2014 17:08:50 +0000 (UTC) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3BBEA2544 for ; Sat, 17 May 2014 17:08:49 +0000 (UTC) Received: by mail-pa0-f42.google.com with SMTP id rd3so3907083pab.29 for ; Sat, 17 May 2014 10:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=CWqU31HoexRLBr6nlxkyLKTXfNKeajdeD53wLeYKHUQ=; b=ZK/fgicyiz6Fucql917r9DbBxyC4NGbd8XJtEMxmO2v3chxr+iVWTiq8XEMB6M3v8p IePX5bCxo8kMbx56ZInKHqwVu02yFbt4QGrhvmBCq3WGDRqJ3BQkoWTOdUnEz/bo6FGK 8dYtGegEnDwOKUSdsKD7W8qpYxXGWsv+DwBN3jjs9pRZhJxflM5SFy5Wdz9MNPZIECXz 4KrfoQPKYicDZWjD7AcinHf9yvnnH0dElIjVGmPKa14MVzE32xwZLrO2FkQkTBMH4qyG vGtlASCPnTJyot+sBQ7FDf2JDsHf3a6GLE7p2yfBhSdEfbp+NlB1U0xRSgfVswgnChvd d/+w== X-Gm-Message-State: ALoCoQnEigpUsyes4uHaFKauKUqFTszuVtQwegt8mijJ7XUORQhHTl0wM8aym0WYb3KeyR09xGhN X-Received: by 10.66.148.197 with SMTP id tu5mr30292607pab.108.1400346529400; Sat, 17 May 2014 10:08:49 -0700 (PDT) Received: from lgmac-ksadekar.corp.netflix.com (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id ih6sm20879680pbc.22.2014.05.17.10.08.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 17 May 2014 10:08:48 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_AFBCE886-6710-44BE-A989-ED3F195BA4D6"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: svn commit: r266278 - head/share/mk From: Warner Losh In-Reply-To: Date: Sat, 17 May 2014 13:08:45 -0400 Message-Id: <7FEE0AEE-A055-4257-8C51-C01B562DCEED@bsdimp.com> References: <201405170147.s4H1l6nW081735@svn.freebsd.org> <3ADF8926-8AEF-4324-A205-2E7D8D5393A2@bsdimp.com> To: Dimitry Andric X-Mailer: Apple Mail (2.1874) Cc: svn-src-head@freebsd.org, "O. Hartmann" , svn-src-all@freebsd.org, src-committers , Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 May 2014 17:08:50 -0000 --Apple-Mail=_AFBCE886-6710-44BE-A989-ED3F195BA4D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On May 17, 2014, at 10:57 AM, Dimitry Andric wrote: > On 17 May 2014, at 16:27, Warner Losh wrote: >>=20 >> On May 17, 2014, at 9:56 AM, Dimitry Andric wrote: >>=20 >>> On 17 May 2014, at 03:47, Warner Losh wrote: >>>> Author: imp >>>> Date: Sat May 17 01:47:06 2014 >>>> New Revision: 266278 >>>> URL: http://svnweb.freebsd.org/changeset/base/266278 >>>>=20 >>>> Log: >>>> Read in SRCCONF early and consistently, if src.sys.mk exists, which = is >>>> should for all normal builds. Read /etc/make.conf earlier than = before, >>>> but consistently before SRCCONF and local.sys.mk. >>>=20 >>> I'm not yet sure why, but this breaks buildworld badly. During = bootstrap-tools, you immediately get: >>=20 >> Haven=92t seen this in my testing. Please send me your /etc/make.conf = and /etc/src.conf. Or tell me your environment. Would love to fix it... >=20 > Try an empty make.conf (or __MAKE_CONF=3D/dev/null), and just this = line in src.conf: >=20 > CXXFLAGS+=3D -std=3Dc++11 >=20 > That breaks it. We define CXXFLAGS later rather than sooner now. CXXFLAGS ?=3D = ${CFLAGS:N-std=3D*:N-Wnested-externs:N-W*-prototypes:N-Wno-pointer-sign:N-= Wold-style-definition} would have been executed, but the change caused that to not happen = (since you effectively set CXXFLAGS to -std=3Dc++11). I=92m not sure what I think of this breakage, but I=92ll look into = correcting it. I=92m not really sure what the proper fix is though=85 Warner --Apple-Mail=_AFBCE886-6710-44BE-A989-ED3F195BA4D6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTd5eeAAoJEGwc0Sh9sBEAb+oQAODPfL2zM+wn0Cngo3QstBEa tuc/+WkSAY6LxlohSNWXFi13ilMXiB6v61r/Rf+eRTHilA+hfwiGS5YCNc6bBGry RR09VBBdVFg8rwBspNi4R2XUvBA/yN+yufIOFUOb067vQl7jI8n4U0D97Bue/C7B t/ds8+wZIU23RLze3PIdDAWvlKWqui4e36vKkMKhSc2d3Og9ak4hHjygSmvEj78q 932nweOE/KMECDt+B5FnybaOZ0YNvE3DIhyWnjeX0rhUCu6YH9nGXJlizzY7dLre EWe+8blGJ95qK9uybyl5p90xC+QSL459ux9ro+f5USCbYt0wGq2jpTkDOQSmQGM2 DgNV35o+jfPi1+n0WlTZyadYN0NuSZJ5KBRnCFb7J/Kbc1bqFRkxkaR9BZTMl7qO 878V1gTgp9yHRbZ+4/rGbR622WmSojsRA3nBBSlrU2ejCxCTvaNxypwtNbjw/UFc bF4FQHE5mUFFfk/yQ0CMtRJbfrM9GZxVnh4E5TiQy9KOsOQqYVzZzhMn5DIcZKKt SaJMRPLanVv0rM7/NGlBDNHpWyqJK3yJTljT7kkvQfol+vFhQWf3dvibvMw6OvZD n7evhH4/xOrbvybBQMFWnEeotZIxrqGQMEQ82py7KtS5t5Oeuz3L3h8dRAzHcLTs U77G9uWxpO5Fp1DuEwzE =2Pzu -----END PGP SIGNATURE----- --Apple-Mail=_AFBCE886-6710-44BE-A989-ED3F195BA4D6--