From owner-svn-src-all@freebsd.org Fri Apr 22 22:02:17 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0AB5AB1935C; Fri, 22 Apr 2016 22:02:17 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-lf0-x22a.google.com (mail-lf0-x22a.google.com [IPv6:2a00:1450:4010:c07::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A0F72111D; Fri, 22 Apr 2016 22:02:16 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-lf0-x22a.google.com with SMTP id g184so86840601lfb.3; Fri, 22 Apr 2016 15:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=RgfTTkbh3oRzCegvitFIH3Z6R/LdMWof+Q196m1OLdU=; b=BdCwqBAKr3xcOO9SrhhUUAn0JCoVZVV9sZcgrI9oGbTGsiicmVfLUkm0hChBGDt93L Klg0h1xtJhrHQM3KsYJ3vKvP3r0Iq6KKnB5R2vH7gHpoZedb+v5RPXnT7TVIqVVF6iDX g+KnxTwHz+THUZZaNr3A2TbjtqAFMUM/Sh8V7RjG3VoXeRq2l00+TnHwrQkTdnONrlLy IR0tdmxcG2xDcjsq5GqvZTpHIdlB/zkCwIgyNbhKQambV2RK2NiUIQspyore5woen7XQ juSkTL5GZX9zvCISKri96f5XiB1Gp3+CHRo3ZZ6YQyQkv7K+104bdA9bTzcV4efNcsxh begg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=RgfTTkbh3oRzCegvitFIH3Z6R/LdMWof+Q196m1OLdU=; b=YXffC3aWiX85/Wkza7w5v0+SsXRUHn2VR1/qXY1Kcth2zUX2Bt/EcqHP1bK8VYU5gX IfDKLe1j0n1HV41UDCACoAhTqz6kZg9HIZWoAU5xqxdIJ9ZeIDiHyxfz19vneYSmxBaU 2NqhU+dejC5KKC7E20ht/V+FcSP4TS7MaSqUsr3P8vCeTan3PtJm4efbVjYVdqpEWhlc 4DfFIVUiViVJWVTnAdACie27xunSIrGc2jEEDmk/15kBrRozm1PLQEc3nm5Wg1CnF3av 30DbvThlmbHexI8kpyvJLzh2nICkgO4iLXh76zHJhP5/V4lSt51znIcQ+py0EDNUMg+B h1LA== X-Gm-Message-State: AOPr4FVPGCSBc0n+P4HQaqGJschN0oa31yD0e5JSYRG1BwvGhgF/ZEtRMfNtTm6iCzKlkvHG15W1lbkEXhALxA== MIME-Version: 1.0 X-Received: by 10.25.78.204 with SMTP id c195mr8196462lfb.21.1461362534770; Fri, 22 Apr 2016 15:02:14 -0700 (PDT) Received: by 10.112.236.33 with HTTP; Fri, 22 Apr 2016 15:02:14 -0700 (PDT) In-Reply-To: <570C6BD4.5030609@FreeBSD.org> References: <201604112115.u3BLFmN9003703@repo.freebsd.org> <570C6BD4.5030609@FreeBSD.org> Date: Fri, 22 Apr 2016 15:02:14 -0700 Message-ID: Subject: Re: svn commit: r297836 - head/lib/msun/tests From: Ngie Cooper To: Bryan Drewery Cc: Garrett Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 22:02:17 -0000 On Mon, Apr 11, 2016 at 8:30 PM, Bryan Drewery wrote= : > On 4/11/2016 2:15 PM, Garrett Cooper wrote: >> Author: ngie >> Date: Mon Apr 11 21:15:48 2016 >> New Revision: 297836 >> URL: https://svnweb.freebsd.org/changeset/base/297836 >> >> Log: >> Fix appending -O0 to CFLAGS > > This seems to be a NOP. > >> >> The previous method would completely nerf CFLAGS once bsd.progs.mk had > > I'm not seeing 'completely nerf' in a diff: >> -/usr/local/bin/ccache cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -= DLDBL_PREC=3D64 -O0 -g -std=3Diso9899:1999 -fstack-protector-strong -Wno-= unknown-pragmas -fcolor-diagnostics -Qunused-arguments -c /root/git/free= bsd/lib/msun/tests/nearbyint_test.c -o nearbyint_test.o >> -cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -DLDBL_PREC=3D64 -O0 -g= -std=3Diso9899:1999 -fstack-protector-strong -Wno-unknown-pragmas -fcolor-= diagnostics -Qunused-arguments -o nearbyint_test.full nearbyint_test.o -= lm >> +/usr/local/bin/ccache cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -= O0 -DLDBL_PREC=3D64 -g -std=3Diso9899:1999 -fstack-protector-strong -Wno-= unknown-pragmas -fcolor-diagnostics -Qunused-arguments -c /root/git/free= bsd/lib/msun/tests/nearbyint_test.c -o nearbyint_test.o >> +cc -O2 -pipe -DHAVE_FENV_H -D__HAVE_LONG_DOUBLE -O0 -DLDBL_PREC=3D64 -g= -std=3Diso9899:1999 -fstack-protector-strong -Wno-unknown-pragmas -fcolor-= diagnostics -Qunused-arguments -o nearbyint_test.full nearbyint_test.o -= lm > > It's simply moving it earlier, since it comes before the CFLAGS+=3D-DLDBL= _PREC > > I diff'd the entire output and all were the same as this. > > Am I missing something? What prompted me to do this (and brought me to this incorrect conclusion) originally is that I was trying to figure out why make -VCFLAGS.fminmax_test wasn't outputting -O* the way I thought it would. After doing some digging, yes... it was a silly nop :(... in retrospect (jhb was right) I shouldn't have MFCed it :/. I'll "revert" the change in the next go-around with this Makefile.. Thanks, -Ngie