Date: Fri, 20 Nov 2015 12:58:46 -0800 From: Conrad Meyer <cemeyer@uw.edu> To: freebsd-hackers@freebsd.org Subject: Re: libUCL / UCL as FreeBSD config question Message-ID: <20151120125846.31d4f4cc@m> In-Reply-To: <564F771F.4060408@freebsd.org> References: <5B598F72-C5DD-48FD-866D-F90E117D646E@rdsor.ro> <564F6118.5030702@freebsd.org> <1448048197.2765.74.camel@michaeleichorn.com> <564F771F.4060408@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 20 Nov 2015 14:40:15 -0500
Allan Jude <allanjude@freebsd.org> wrote:
> The issue is that UCL allows comments anywhere, for example:
>
> #above
> FreeBSD: {
> /* before */ url:
> "pkg+http://pkg.FreeBSD.org/${ABI}/latest", mirror_type: /*
> middle */ "srv", signature_type: "fingerprints", /* after */
> # under
> fingerprints: "/root/keys/pkg", # inline-after
> enabled: yes
> }
>
> Etc. So the solution that was discussed was changing libucl
> to use an Abstract Syntax Tree, but that is a lot of work.
> So for now, I am not sure what the best approach is.
I think an AST that keeps comments is a good approach going
forwards. We don't need a short-term fix that is anything
less than that.
Best,
Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151120125846.31d4f4cc>