From owner-svn-ports-all@FreeBSD.ORG  Mon Apr 14 10:03:18 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id EBB38C05; Mon, 14 Apr 2014 10:03:18 +0000 (UTC)
Date: Mon, 14 Apr 2014 10:03:18 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Johannes Jost Meixner <xmj@FreeBSD.org>
Subject: Re: svn commit: r351187 - head/games/linux-nwserver
Message-ID: <20140414100318.GA51290@FreeBSD.org>
References: <201404130751.s3D7pvPK013643@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201404130751.s3D7pvPK013643@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Apr 2014 10:03:19 -0000

On Sun, Apr 13, 2014 at 07:51:57AM +0000, Johannes Jost Meixner wrote:
> New Revision: 351187
> URL: http://svnweb.freebsd.org/changeset/ports/351187
> QAT: https://qat.redports.org/buildarchive/r351187/
> 
> +COMMENT=	Neverwinter Nights Linux Dedicated Server

We usually avoid excessive caps in COMMENT (e.g. it better be "dedicated
server").

> +.include <bsd.port.options.mk>
> +
> [...]
> -.ifndef (NOPORTDOCS)
> -	@${MKDIR} ${DOCSDIR}
> -	${INSTALL_DATA} ${WRKDIR}/readme.linuxserver.txt ${DOCSDIR}
> +.if ${PORT_OPTIONS:MDOCS}
> +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> +	${INSTALL_DATA} ${WRKDIR}/readme.linuxserver.txt ${STAGEDIR}${DOCSDIR}

For docs that do not require generation (i.e. they are shipped with the
ported software), once you stage the port, checking PORT_OPTIONS:MDOCS is
no longer needed (and allows you to remove .include <bsd.port.options.mk>
in this case).

./danfe