From owner-svn-src-all@freebsd.org Fri May 25 16:40:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC720EED94F; Fri, 25 May 2018 16:40:11 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8BFFF68DB8; Fri, 25 May 2018 16:40:11 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 52ADC1B3EC; Fri, 25 May 2018 16:40:11 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f53.google.com with SMTP id y189-v6so7560503itb.2; Fri, 25 May 2018 09:40:11 -0700 (PDT) X-Gm-Message-State: ALKqPwdpvssf6t27ydHDqEOn9+CqAUDBKiOHprONzMTk6DhsHiwBvFLf sXkyl/qFY5cttleWrleUnyX5t2k9B6pOGmTxD/0= X-Google-Smtp-Source: AB8JxZrjnygbN56XKahbzPqFdZUYglmMtl02+YkS2OxMt/ZeSk3eCe5ly9Wth0ijaCgH+yJJcbrtDOLxNzgmsfxC40M= X-Received: by 2002:a24:5b54:: with SMTP id g81-v6mr2715637itb.7.1527266410721; Fri, 25 May 2018 09:40:10 -0700 (PDT) MIME-Version: 1.0 References: <201805232102.w4NL2FaJ073854@repo.freebsd.org> <20180525163604.GA40082@raichu> In-Reply-To: <20180525163604.GA40082@raichu> From: Matthew Macy Date: Fri, 25 May 2018 09:40:00 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334118 - in head/sys: compat/linprocfs compat/linux compat/linuxkpi/common/include/linux dev/mlx5/mlx5_ib dev/wtap net net/altq netinet netinet/netdump netinet6 netpfil/pf nfs ofed/dri... To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 16:40:12 -0000 Odd. I tested the same thing as did pho with regular interfaces. Will fix asap. On Fri, May 25, 2018 at 09:36 Mark Johnston wrote: > On Wed, May 23, 2018 at 09:02:15PM +0000, Matt Macy wrote: > > Author: mmacy > > Date: Wed May 23 21:02:14 2018 > > New Revision: 334118 > > URL: https://svnweb.freebsd.org/changeset/base/334118 > > > > Log: > > UDP: further performance improvements on tx > > > > Cumulative throughput while running 64 > > netperf -H $DUT -t UDP_STREAM -- -m 1 > > on a 2x8x2 SKL went from 1.1Mpps to 2.5Mpps > > > > Single stream throughput increases from 910kpps to 1.18Mpps > > > > Baseline: > > https://people.freebsd.org/~mmacy/2018.05.11/udpsender2.svg > > > > - Protect read access to global ifnet list with epoch > > https://people.freebsd.org/~mmacy/2018.05.11/udpsender3.svg > > > > - Protect short lived ifaddr references with epoch > > https://people.freebsd.org/~mmacy/2018.05.11/udpsender4.svg > > > > - Convert if_afdata read lock path to epoch > > https://people.freebsd.org/~mmacy/2018.05.11/udpsender5.svg > > After this change I can panic an INVARIANTS kernel like so. There is a > freed ifaddr lingering on the lo0 ifnet's address list. > > # ifconfig lo0 127.0.0.2 > # ifconfig lo0 -alias 127.0.0.2 > # netstat -rn > Routing tables > > > Fatal trap 9: general protection fault while in kernel mode > cpuid = 1; apic id = 01 > instruction pointer = 0x20:0xffffffff80605219 > stack pointer = 0x28:0xfffffe00004692e0 > frame pointer = 0x28:0xfffffe00004693d0 > code segment = base 0x0, limit 0xfffff, type 0x1b > = DPL 0, pres 1, long 1, def32 0, gran 1 > processor eflags = interrupt enabled, resume, IOPL = 0 > current process = 735 (netstat) > trap number = 9 > panic: general protection fault > cpuid = 1 > time = 1527266002 > Uptime: 1m42s > Dumping 216 out of 4079 > MB:..8%..15%..23%..37%..45%..52%..67%..74%..82%..97% > Dump complete > Consoles: userboot >