From owner-cvs-all@FreeBSD.ORG  Sat Jun 16 20:31:41 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E662516A46D;
	Sat, 16 Jun 2007 20:31:41 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id D00CE13C484;
	Sat, 16 Jun 2007 20:31:41 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id 3EC6F1A3C1A;
	Sat, 16 Jun 2007 13:31:04 -0700 (PDT)
Received: from rot13.obsecurity.org (rot13.obsecurity.org [192.168.1.5])
	by obsecurity.dyndns.org (Postfix) with ESMTP id 0C453512A6;
	Sat, 16 Jun 2007 16:31:40 -0400 (EDT)
Received: by rot13.obsecurity.org (Postfix, from userid 1001)
	id 9F9B7BE98; Sat, 16 Jun 2007 16:31:40 -0400 (EDT)
Date: Sat, 16 Jun 2007 16:31:40 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: Kris Kennaway <kris@obsecurity.org>, Rong-En Fan <rafan@FreeBSD.org>,
	ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org
Message-ID: <20070616203140.GA29419@rot13.obsecurity.org>
References: <200706161925.l5GJPkGq098836@repoman.freebsd.org>
	<20070616202130.GA29198@rot13.obsecurity.org>
	<20070616202747.GP90672@droso.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070616202747.GP90672@droso.net>
User-Agent: Mutt/1.4.2.3i
Cc: 
Subject: Re: cvs commit: ports/devel/libdasm Makefile distinfo pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jun 2007 20:31:42 -0000

On Sat, Jun 16, 2007 at 10:27:47PM +0200, Erwin Lansing wrote:
> On Sat, Jun 16, 2007 at 04:21:30PM -0400, Kris Kennaway wrote:
> > On Sat, Jun 16, 2007 at 07:25:46PM +0000, Rong-En Fan wrote:
> > > rafan       2007-06-16 19:25:46 UTC
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     devel/libdasm        Makefile distinfo pkg-plist 
> > >   Log:
> > >   - Update to 1.5 [1]
> > >   - Replace deprecated variable: INSTALLS_SHLIB
> > >   - Use PORTDOCS to simplify pkg-plist
> > >   
> > >   PR:            ports/113760 [1]
> > >   Submitted by:  Antoine Brodin <antoine.brodin at laposte.net> (maintainer)
> > >   Approved by:   Antoine Brodin <antoine.brodin at laposte.net> (maintainer)
> > 
> > It's reasonable to assume that changes submitted by a maintainer are
> > self-approved, so the duplication isn't necessary :)
> > 
> It took me a while to parse it as well and wanted to send the same
> message, but I figured that the submitted line goes with [1] and the
> approved with the other two.  The message seems right afterall, though
> confusing at best :-)

Ah, OK.  In this case we typically do something like

Log:
 - Update to 1.5 [1]
 - Replace deprecated variable: INSTALLS_SHLIB [2]
 - Use PORTDOCS to simplify pkg-plist [2]

 PR:            ports/113760 [1]

Submitted by:  Antoine Brodin <antoine.brodin at laposte.net> (maintainer) [1]
Approved by:   Antoine Brodin <antoine.brodin at laposte.net> (maintainer) [2]

to disambiguate.  I guess it's not important in this case though.

Kris