From owner-svn-ports-all@freebsd.org  Sat May 28 20:03:01 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0494FB4EFB9;
 Sat, 28 May 2016 20:03:01 +0000 (UTC) (envelope-from pi@FreeBSD.org)
Received: from fc.opsec.eu (fc.opsec.eu [IPv6:2001:14f8:200:4::4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B7F151A5C;
 Sat, 28 May 2016 20:03:00 +0000 (UTC) (envelope-from pi@FreeBSD.org)
Received: from pi by fc.opsec.eu with local (Exim 4.87 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1b6kRj-000POL-1Z; Sat, 28 May 2016 22:02:55 +0200
Date: Sat, 28 May 2016 22:02:55 +0200
From: Kurt Jaeger <pi@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r416053 - head/Mk/Uses
Message-ID: <20160528200254.GI1036@fc.opsec.eu>
References: <201605281719.u4SHJiAa008852@repo.freebsd.org>
 <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 May 2016 20:03:01 -0000

Hi!

> |  .if !target(do-configure) && ! ${qmake_ARGS:M_env}
> | -_USES_configure+=	450:qmake-configure
> | +do-configure: qmake-configure
> | +	@${DO_NADA}
> |  .endif
> 
> I should explain a bit more.
> 
> This goes against the Right Way Of Doing Things(c)(r)(tm).
> 
> To add a target to be run in the targets pipeline, you use _USES_xxx, you
> never, ever, piggyback on an existing target, especially if you're not
> using it.
> 
> So, please, back this out.

Done. I'm not sure *why* the kde folks requested this change
in the first place, so I'll ask them.

-- 
pi@FreeBSD.org         +49 171 3101372                4 years to go !