From nobody Fri Feb 17 17:49:00 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJK7M4l04z3rDPK; Fri, 17 Feb 2023 17:49:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJK7M4Cnbz3qDG; Fri, 17 Feb 2023 17:49:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676656143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TqVPO7GnClqIdyts5m8v2qtx3wNKVhXk/v2F/efJRTY=; b=hVQoX59q2W/d4ckYIptB8Z5WvmhxG9X/KNNmqk2cX9qFIhRDBwOsb5eBkb/FBWOou0HRK3 kbw5oycap/NkBDtTvSmNfYhWEvy9XFrUBaZyeQ9z0lC99JM8sgt5LCfEFVhEBsXgvgkJW+ aeiSWrGUMfJS4hbKJIWE6EmwC4hCSBMTE4qSDhDba/3WucRjMAtnJ1THPOe72qjt/qlVQA xmck64H+2N3HXwa+LL+6///GZhtNzU1uiGiEIX4lsFOK+y+J/EkJRXN6Iu+hxAzGTEB3u1 hE5ldqBRqIy94pV6IoaKlgxQjSAOXKkycUThQeS0yv7F38cZatXC7Uzh8jNgCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676656143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TqVPO7GnClqIdyts5m8v2qtx3wNKVhXk/v2F/efJRTY=; b=pg3xRhpUNQBgAoL1fW88r/sQUIrwMP78t3HuBvu9IssDOUDTws/QsPTRWuNJVvdef3Ki/7 U6O92HCnAoIEHecQgwrnRqV4exk+jkfiII6TE893FqM0ALrzXU+aarHy+49Ut5cozHJXQw 8/jnz50/uECzeP3J8nlvrRCdqtnU+PlFUzh9Y+OrK13fNj3rYLabRkR2pWwEOgQoZ7lqub 0Ndqox5q1rPtIlWXcr8dpZ6edPgEWbe3WpiwXz3EEeCuSYNLu6pYIo2VRMF3EcvvCFYeS9 ZyzEwhuDClnhPG8KynFr0no/0NHbMsirPz6YpP3jJkceg+3A2Gg5ZB6KFzGQ2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676656143; a=rsa-sha256; cv=none; b=Lmrv1Z2+bcsQQvaOpnboyAXTFqLyUUzQaDaaco0VLZgTtI9UT0r39/EgACT2yb0ePmVB/O IEep5vchSQmHp2rDggkqEYfeqxm/IJ4ECMSCcwaqJc6KIW2WoML/dTY7hRF30nVL8+4JF2 O/yj7YsTst0sgQDrburPiyxyMMXuCwxt+aRQrKKnLNFsxiTgP+FHtYF1zb5hvwChrDi2vT /i0Tnw6fCok16htkUpg5ytK+s+rFiLplV0jY45a2gyYKFd5cPx8/QjXQ/jVaXBbv+Jc8cK A8/e19UNBgxiqbRX4Xe0+NUkE4Eb/z3KCbmZt4yVN8JflvX7USpkANInuHg9AQ== Received: from [IPV6:2601:648:8680:16b0:10b2:ebc3:c7be:fc24] (unknown [IPv6:2601:648:8680:16b0:10b2:ebc3:c7be:fc24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PJK7L6kj6znM2; Fri, 17 Feb 2023 17:49:02 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <2fb2622d-8aae-af37-2e52-df7f20e27646@FreeBSD.org> Date: Fri, 17 Feb 2023 09:49:00 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: git: 98844e99d40a - main - aio: Fix more synchronization issues in aio_biowakeup. Content-Language: en-US To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202302152133.31FLXEep021521@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 2/15/23 2:05 PM, Alan Somers wrote: > On Wed, Feb 15, 2023 at 2:33 PM John Baldwin wrote: >> >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=98844e99d40a90ae89d84762e07150af3a8f89bd >> >> commit 98844e99d40a90ae89d84762e07150af3a8f89bd >> Author: John Baldwin >> AuthorDate: 2023-02-15 21:32:52 +0000 >> Commit: John Baldwin >> CommitDate: 2023-02-15 21:32:52 +0000 >> >> aio: Fix more synchronization issues in aio_biowakeup. >> >> - Use atomic_store to set job->error. atomic_set does an or >> operation, not assignment. >> >> - Use refcount_* to manage job->nbio. >> >> This ensures proper memory barriers are present so that the last bio >> won't see a possibly stale value of job->error. >> >> - Don't re-read job->error after reading it via atomic_load. >> >> Reported by: markj (1) >> Reviewed by: mjg, markj >> Differential Revision: https://reviews.freebsd.org/D38611 > > Thanks for fixing these subtle problems in aio_(read|write)v. Will you MFC too? Yes. I only noticed these while reviewing the original fix from the folks at TidalScale FWIW. -- John Baldwin