Date: Wed, 26 Aug 2020 20:19:21 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Brandon Bergren <bdragon@imap.cc> Cc: Alan Somers <asomers@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364799 - in head: share/man/man9 sys/crypto/ccp sys/dev/cxgbe/crypto sys/dev/sec sys/kern sys/opencrypto Message-ID: <2534D2E5-2974-4067-8B9C-53EE3E8C6A68@freebsd.org> In-Reply-To: <7e0abc1a-a397-46c3-b283-2c1ab21a9c4d@www.fastmail.com> References: <202008260237.07Q2bhwF045988@repo.freebsd.org> <7e0abc1a-a397-46c3-b283-2c1ab21a9c4d@www.fastmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 Aug 2020, at 20:16, Brandon Bergren <bdragon@imap.cc> wrote: > On Tue, Aug 25, 2020, at 9:37 PM, Alan Somers wrote: >> Author: asomers >> Date: Wed Aug 26 02:37:42 2020 >> New Revision: 364799 >> URL: https://svnweb.freebsd.org/changeset/base/364799 >>=20 >> Modified: head/sys/dev/sec/sec.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/dev/sec/sec.c Wed Aug 26 02:13:27 2020 = (r364798) >> +++ head/sys/dev/sec/sec.c Wed Aug 26 02:37:42 2020 = (r364799) >> @@ -851,6 +851,9 @@ sec_desc_map_dma(struct sec_softc *sc, struct = sec_dma_ >> case CRYPTO_BUF_MBUF: >> size =3D m_length(crp->crp_buf.cb_mbuf, NULL); >> break; >> + case CRYPTO_BUF_VMPAGE: >> + size =3D PAGE_SIZE - cb->cb_vm_page_offset; >> + break; >> default: >> return (EINVAL); >> } >=20 > Uh, where is cb coming from? Shouldn't this be using = crp->crp_buf.cb_vm_page_offset? This is causing a build failure on = powerpc and powerpcspe. I don't see why other platforms aren't also = erroring out here. Because it's PowerPC-specific: sys/conf/files.powerpc:dev/sec/sec.c optional sec mpc85xx Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2534D2E5-2974-4067-8B9C-53EE3E8C6A68>